Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prod s3 proxy uri 변경 #728

Merged
merged 1 commit into from
Oct 28, 2021
Merged

feat: prod s3 proxy uri 변경 #728

merged 1 commit into from
Oct 28, 2021

Conversation

sakjung
Copy link
Collaborator

@sakjung sakjung commented Oct 28, 2021

구현 기능

  • cluster 내부 pod 끼리의 통신을 위해 Service DNS를 사용하도록 수정했습니다.
  • 이는 유동적인 clusterIP를 사용하는 방법보다 더 안전하고 편리한 방법이라고 생각합니다.
  • 우리가 EC2 IP를 DNS에 등록해서 사용하는 것과 같은 이치라고 생각하시면 됩니다.

Close #727

@sakjung sakjung added 🌟 feature New feature or request 🕋 backend labels Oct 28, 2021
@sakjung sakjung self-assigned this Oct 28, 2021
@sakjung
Copy link
Collaborator Author

sakjung commented Oct 28, 2021

✅ ZZIMKKONG SONARQUBE ✅

All passes! - Read the report here!

dusdn1702
dusdn1702 approved these changes Oct 28, 2021
View reviewed changes
Copy link
Collaborator

@dusdn1702 dusdn1702 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http 없어도 되는거지요??

@sakjung
Copy link
Collaborator Author

sakjung commented Oct 28, 2021

http 없어도 되는거지요??

네 ㅎㅎ 확인했습니다!

@sakjung sakjung merged commit 73e3091 into dev Oct 28, 2021
@sakjung sakjung deleted the feat/727-kube-dns branch October 28, 2021 12:06
@xrabcde xrabcde mentioned this pull request Oct 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrabcde xrabcde xrabcde approved these changes

@dusdn1702 dusdn1702 dusdn1702 approved these changes

@tributetothemoon tributetothemoon Awaiting requested review from tributetothemoon

Assignees

@sakjung sakjung

Labels
🕋 backend 🌟 feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] Kubernetes pod 간 통신 DNS 활용하도록 수정
3 participants
@sakjung @dusdn1702 @xrabcde