Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: DB Replication, Redis 관련 설정 제거 #754

Merged
merged 6 commits into from
Jan 7, 2022
Merged

refactor: DB Replication, Redis 관련 설정 제거 #754

merged 6 commits into from
Jan 7, 2022

Conversation

xrabcde
Copy link
Collaborator

@xrabcde xrabcde commented Dec 31, 2021 •
edited
Loading

구현 기능

  • DataSourceConfig 설정을 제거했습니다.
  • Spring datasource 설정을 변경했습니다. > 서브모듈 업데이트 필요
    • was와 db를 한 인스턴스에 띄워도 될 것 같아서 이전에 db 서버 분리하기 전처럼 localhost:3306으로 datasource 설정해두었는데 이 부분은 논의해보고 변경해도 됩니다~
  • prod properties에 redis 관련 설정을 제거했습니다. > 서브모듈 업데이트 필요
  • CacheConfig 관련 코드를 정리했습니다.

Close #752, #753

@xrabcde xrabcde added 🕋 backend 🔨 refactor ⛑ infra 인프라, DB 관련 이슈 labels Dec 31, 2021
@xrabcde xrabcde self-assigned this Dec 31, 2021
@xrabcde xrabcde changed the title refactor: DB Replication 관련 설정 제거 refactor: DB Replication, DB Redis 관련 설정 제거 Dec 31, 2021
@xrabcde xrabcde changed the title refactor: DB Replication, DB Redis 관련 설정 제거 refactor: DB Replication, Redis 관련 설정 제거 Dec 31, 2021
@xrabcde xrabcde linked an issue Dec 31, 2021 that may be closed by this pull request
[BE] DB Redis 관련 설정을 제거한다. #753
Closed
2 tasks
tributetothemoon
tributetothemoon previously approved these changes Jan 1, 2022
View reviewed changes
Copy link
Collaborator

@tributetothemoon tributetothemoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

많이 정리되네요. 고생하셨습니다!

dusdn1702
dusdn1702 previously approved these changes Jan 1, 2022
View reviewed changes
Copy link
Collaborator

@dusdn1702 dusdn1702 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다이어트 동의합니다.

@xrabcde xrabcde dismissed stale reviews from dusdn1702 and tributetothemoon via 5472f79 January 7, 2022 05:38
dusdn1702
dusdn1702 approved these changes Jan 7, 2022
View reviewed changes
Copy link
Collaborator

@dusdn1702 dusdn1702 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gooooood

@xrabcde xrabcde merged commit 8a3212e into dev Jan 7, 2022
@xrabcde xrabcde deleted the feat/752-replication-refactor branch January 7, 2022 06:36
@sakjung
Copy link
Collaborator

sakjung commented Jan 7, 2022

저도 모두 확인했습니다!

This was referenced Apr 27, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tributetothemoon tributetothemoon tributetothemoon approved these changes

@dusdn1702 dusdn1702 dusdn1702 approved these changes

@sakjung sakjung Awaiting requested review from sakjung

Assignees

@xrabcde xrabcde

Labels
🕋 backend ⛑ infra 인프라, DB 관련 이슈 🔨 refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] DB Redis 관련 설정을 제거한다. [BE] DB Replication 관련 설정을 제거한다.
4 participants
@xrabcde @sakjung @dusdn1702 @tributetothemoon