Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: jacoco, sonarqube 관련 설정 제거 #760

Merged
merged 2 commits into from
Jan 21, 2022
Merged

refactor: jacoco, sonarqube 관련 설정 제거 #760

merged 2 commits into from
Jan 21, 2022

Conversation

dusdn1702
Copy link
Collaborator

구현 기능

  • jacoco, sonarqube가 더이상 동작하지 않도록 제거했습니다.
  • s3 쪽 테스트가 fail하길래 disabled 처리해두었습니다.

논의하고 싶은 내용

  • 어차피 빌드는 테스트가 터지면 실패하니, 특별히 커버리지를 낮춰야하는 이유가 없다면 jacoco 정도는 살려도 되지 않을까? 라는 개인적인 생각이 있습니다.
  • sonarqube는 사실상 major한 문제 관찰용이었으니 없어도 되겠지만 이거도 서버 안띄우고 돌릴 수는 있을 것 같습니다. 그치만 더이상 comment가 달리지 않으니 필요가 없다는 생각입니다.

Close #759

@dusdn1702 dusdn1702 self-assigned this Jan 11, 2022
xrabcde
xrabcde approved these changes Jan 11, 2022
View reviewed changes
Copy link
Collaborator

@xrabcde xrabcde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good~

...nd/src/test/java/com/woowacourse/zzimkkong/infrastructure/thumbnail/S3ProxyUploaderTest.java
@@ -27,6 +28,7 @@

@SpringBootTest
@ActiveProfiles("test")
@Disabled
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋㅋㅋㅋㅋ 편-안

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이제 s3 테스트들은 삭제되었습니다 ㅎㅅ

@xrabcde xrabcde merged commit a00763b into dev Jan 21, 2022
@xrabcde xrabcde deleted the refactor/759-remove-jacoco branch January 21, 2022 04:44
This was referenced Apr 27, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tributetothemoon tributetothemoon tributetothemoon approved these changes

@xrabcde xrabcde xrabcde approved these changes

@sakjung sakjung Awaiting requested review from sakjung

Assignees

@dusdn1702 dusdn1702

Labels
🕋 backend 🔨 refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] Jacoco와 소나큐브 관련 설정을 제거한다.
3 participants
@dusdn1702 @tributetothemoon @xrabcde