refactor: 관리자 메인 페이지에서 썸네일을 png대신 svg로 보여주도록 수정 #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- mapImageSvg -> thumbnail
- mapImagesSvg -> thumbnail
Puterism
approved these changes
Feb 2, 2022
| loading="lazy" | ||
| /> | ||
| </Styled.ImageInner> | ||
| <Styled.ImageInner dangerouslySetInnerHTML={{ __html: `${thumbnail}` }} /> |
There was a problem hiding this comment.
해당 부분에 대한 리팩토링 이슈를 별도로 올려두겠습니다! 꼭 걷어내는 것으로...
SunYoungKwon
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현 기능
공유하고 싶은 내용
mapImageSvg->thumbnailDrawer->MapListItem컴포넌트에서dangerouslySetInnerHTML을 사용 했습니다.Close #763