feat: 맵별 공지사항 보여주는 기능 추가 #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tributetothemoon
previously approved these changes
May 6, 2022
| @Description("100자 이상 공지사항이 들어오면 예외를 반환한다.") | ||
| void noticeLengthOverSizeLimit() { | ||
| NoticeCreateRequest noticeCreateRequest = new NoticeCreateRequest( | ||
| "iamtenwordiamtenwordiamtenwordiamtenwordiamtenwordiamtenwordiamtenwordiamtenwordiamtenwordiamtenword1"); |
5 tasks
xrabcde
requested changes
May 6, 2022
| @PostMapping("/{mapId}/notice") | ||
| public ResponseEntity<Void> createNotice( | ||
| @PathVariable final Long mapId, | ||
| @RequestBody final NoticeCreateRequest noticeCreateRequest, |
There was a problem hiding this comment.
Suggested change
| @RequestBody final NoticeCreateRequest noticeCreateRequest, | |
| @Valid @RequestBody final NoticeCreateRequest noticeCreateRequest, |
🤔
Comment on lines
+23
to
+24
| final String slackUrl, | ||
| final String notice, |
tributetothemoon
approved these changes
May 6, 2022
dusdn1702
approved these changes
May 8, 2022
| @Getter | ||
| @NoArgsConstructor | ||
| public class NoticeCreateRequest { | ||
| @Size(max = 100, message = DESCRIPTION_MESSAGE) |
There was a problem hiding this comment.
Max 100인데 lob이네용
별 상관은 없겠지만~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현 기능
Close #811 #818