Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 슬랙예약알림 메시지에 교육장 정보 추가 #834

Merged
merged 3 commits into from
Aug 7, 2022

Conversation

xrabcde
Copy link
Collaborator

@xrabcde xrabcde commented Jul 24, 2022

구현 기능

  • 슬랙 예약알림 메시지에 교육장 정보도 같이 보여지도록 추가했습니다.
    • 장소 : 잠실 캠퍼스

의논하고 싶은 내용

  • 일단은 우테코에서만 슬랙알림을 쓰고 있어서 필드이름을 교육장명이라고 하긴 했는데 범용적으로 사용되길 원하시면 맵이름... 뭐 그런걸로 바꿔야 하긴 합니다. 이부분은 의견 주세요1!
    => 장소 로 결정!

기타

  • 귀찮을 줄 알고 계속 미뤘는데 해보니까 생각보다 수정할 게.. 없네요...? 그냥 머지하면 될듯....

Close #798

Copy link
Collaborator

@tributetothemoon tributetothemoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 고생하셨습니다🙇🏻.

Copy link
Collaborator

@sakjung sakjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다~

final String spaceName,
final String userName,
final LocalDateTime startTime,
final LocalDateTime endTime,
final String description,
final String sharingMapId,
final String slackUrl) {
this.mapName = "장소 : " + mapName;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeeeeee

@xrabcde xrabcde merged commit ce6092e into dev Aug 7, 2022
@xrabcde xrabcde deleted the feat/798-refactor-slack-noti branch August 7, 2022 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BE] 슬랙 예약알림 리팩터링한다.
3 participants