feat: 내 예약 목록에서 예약 수정, 삭제 하기 #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunYoungKwon
commented
Jan 25, 2023
| import { useInfiniteQuery } from 'react-query'; | ||
| import { queryMemberReservationHistory } from './../../api/guestReservation'; | ||
|
|
||
| const useMemberReservationHistory = () => { |
There was a problem hiding this comment.
return 타입 없다고 노란줄 뜨는데, 타입지정을 못하겠어요...넘 너려움ㅠ
There was a problem hiding this comment.
사실 추론이 잘 되기때문에 꼭 필요한가..? 싶은 의문도 있습니다.
There was a problem hiding this comment.
저도 커스텀 훅이나 컴포넌트에 대해서는 명시적인 타입 선언이 필요한가? 하는 생각이 들어요. 나중에 ESLint rule을 수정하는 방향으로 가면 좋을 것 같아요.
SunYoungKwon
requested review from
Puterism and
yujo11
and removed request for
Puterism
SunYoungKwon
commented
Jan 25, 2023
|
UI가 넘나리 이쁘네요 고생 많았썬 👍 👍 👍 내일 |
Puterism
approved these changes
Jan 27, 2023
| import { useInfiniteQuery } from 'react-query'; | ||
| import { queryMemberReservationHistory } from './../../api/guestReservation'; | ||
|
|
||
| const useMemberReservationHistory = () => { |
There was a problem hiding this comment.
저도 커스텀 훅이나 컴포넌트에 대해서는 명시적인 타입 선언이 필요한가? 하는 생각이 들어요. 나중에 ESLint rule을 수정하는 방향으로 가면 좋을 것 같아요.
yujo11
approved these changes
Jan 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현 기능
논의하고 싶은 내용
Close #881