feat: 로그인한 상태에서 예약을 추가/수정하는 기능 구현 #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puterism
changed the title
Puterism
commented
Jan 26, 2023
frontend/src/api/api.ts
Outdated
| @@ -43,8 +43,6 @@ api.interceptors.response.use( | |||
| (error: AxiosError<ErrorResponse>) => { | |||
| if (error?.response?.status === 401) { | |||
| removeLocalStorageItem({ key: LOCAL_STORAGE_KEY.ACCESS_TOKEN }); | |||
|
|
|||
| history.push(PATH.LOGIN); | |||
There was a problem hiding this comment.
해당 코드로 인해 비회원 예약할 때 내 정보를 불러오는 로직에서 401로 응답이 와서 비회원 예약 페이지 접근 시 로그인 페이지로 리다이렉트되는 문제가 있습니다.
우선 삭제해두었는데, 해당 라인으로 인해 다른 곳에 문제가 발생할 수 있다면 추가로 논의가 필요할 것 같습니다.
There was a problem hiding this comment.
비회원에서 내 정보를 불러오지 않도록 처리해야하지 않을까요?
There was a problem hiding this comment.
저도 선영님 의견에 동의합니다용
내 정보를 불러오는 로직에 enabled 옵션을 통해서 로그인 됐을 때만 query를 실행하도록 하면 좋으럭 같아용
There was a problem hiding this comment.
유조의 조언대로 useMember 에 enabled 옵션을 추가해서 처리 완료했습니다.
There was a problem hiding this comment.
f73b33b 에서 처리했습니다
yujo11
reviewed
Jan 27, 2023
| @@ -49,6 +65,9 @@ const GuestReservation = (): JSX.Element => { | |||
|
|
|||
| const isEditMode = !!reservation; | |||
|
|
|||
| const member = useMember(); | |||
| const userName = member.data?.data.userName; | |||
|
|
|||
| const getReservations = useGuestReservations( | |||
Puterism
force-pushed
the
feat/868-member-guest-reservation
branch
from
bd8d3f0 to
f73b33b
Compare
SunYoungKwon
approved these changes
Jan 27, 2023
yujo11
approved these changes
Jan 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현 기능
- 로그인한 상태에서 예약을 삭제하는 기능 구현Close #868