Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 내 정보 수정 페이지 UI 및 API 연동 구현 #924

Merged
merged 2 commits into from
Mar 12, 2023

Conversation

Puterism
Copy link
Collaborator

구현 기능

  • 내 정보 수정 페이지 UI 및 API 연동 구현

스크린샷 2023-03-12 오후 6 57 55

Close #914

@Puterism Puterism requested review from yujo11 and SunYoungKwon March 12, 2023 09:58
@Puterism Puterism self-assigned this Mar 12, 2023
@Puterism Puterism added 🌟 feature New feature or request 📚 frontend labels Mar 12, 2023
Comment on lines -18 to +25
<Styled.OranizationTextContainer>
<Styled.OrganizationTextContainer>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오타가 있었군요 ㅋㅋㅋㅋ

<Styled.PageTitle>내 정보 수정</Styled.PageTitle>
<ProfileEditForm onSubmit={handleSubmit} />
<Styled.PasswordChangeLinkMessage>
비밀번호를 변경하고 싶으신가요?
Copy link
Collaborator

@yujo11 yujo11 Mar 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네니요

import * as Styled from './ProfileEditForm.styles';

interface ProfileEditFormProps {
onSubmit?: ({ userName, emoji }: { userName: string; emoji: string }) => void;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요깁니다용

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9456720 에서 반영하였습니다.

@Puterism Puterism requested a review from yujo11 March 12, 2023 10:04
Copy link
Collaborator

@yujo11 yujo11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍 👍

@Puterism Puterism merged commit b896406 into dev Mar 12, 2023
@Puterism Puterism deleted the feat/914-profile-edit branch March 12, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 feature New feature or request 📚 frontend
Projects
None yet
3 participants