Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 예약 화면에서 로그인 후, 예약 화면으로 바로 돌아가는 기능 구현 #988

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

Puterism
Copy link
Collaborator

@Puterism Puterism commented Apr 1, 2024

구현 기능

  • 예약 화면에서 로그인 후, 예약 화면으로 바로 돌아가는 기능 구현
    • 로컬 환경에서는 테스트가 불가하여, 배포 후 테스트를 진행해야 합니다.

Close #986

@Puterism Puterism added 🌟 feature New feature or request 📚 frontend labels Apr 1, 2024
@Puterism Puterism requested review from SunYoungKwon and yujo11 April 1, 2024 09:53
@Puterism Puterism self-assigned this Apr 1, 2024
Copy link
Collaborator

@yujo11 yujo11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~~~ 👍 👍 👍

@@ -27,7 +27,7 @@ const buttonCSS = css`
border-radius: 0.125rem;
`;

export const SocialLoginButton = styled.a<LoginButtonProps>`
export const SocialLoginButton = styled.button<LoginButtonProps>`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

버튼으로 변경되었군요

@@ -1,20 +1,20 @@
import THROW_ERROR from 'constants/throwError';

export const getLocalStorageItem = ({
export const getLocalStorageItem = <T = unknown>({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

체프 T야? 농담이고 확장성 있게 만든 부분 아주 좋네요 👍 👍 👍

import useGoogleLogin from 'hooks/query/useGoogleLogin';
import useQueryString from 'hooks/useQueryString';
import { AccessTokenContext } from 'providers/AccessTokenProvider';
import { LoginSuccess, SocialLoginFailure } from 'types/response';
import { getLocalStorageItem, removeLocalStorageItem } from 'utils/localStorage';

const GoogleOAuthRedirect = (): JSX.Element => {
const history = useHistory();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

history 뭔가 오랜만에 보는 느낌 ㅋㅋㅋ

Copy link
Collaborator

@SunYoungKwon SunYoungKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Puterism Puterism merged commit 3ee3264 into dev Apr 4, 2024
2 checks passed
@Puterism Puterism deleted the feat/986-login-redirect branch April 4, 2024 12:44
@sakjung sakjung mentioned this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 feature New feature or request 📚 frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FE] 로그인 후 이전 화면으로 리다이렉션 처리 (CS)
3 participants