-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 예약 화면에서 로그인 후, 예약 화면으로 바로 돌아가는 기능 구현 #988
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다~~~ 👍 👍 👍
@@ -27,7 +27,7 @@ const buttonCSS = css` | |||
border-radius: 0.125rem; | |||
`; | |||
|
|||
export const SocialLoginButton = styled.a<LoginButtonProps>` | |||
export const SocialLoginButton = styled.button<LoginButtonProps>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
버튼으로 변경되었군요
@@ -1,20 +1,20 @@ | |||
import THROW_ERROR from 'constants/throwError'; | |||
|
|||
export const getLocalStorageItem = ({ | |||
export const getLocalStorageItem = <T = unknown>({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
체프 T야? 농담이고 확장성 있게 만든 부분 아주 좋네요 👍 👍 👍
import useGoogleLogin from 'hooks/query/useGoogleLogin'; | ||
import useQueryString from 'hooks/useQueryString'; | ||
import { AccessTokenContext } from 'providers/AccessTokenProvider'; | ||
import { LoginSuccess, SocialLoginFailure } from 'types/response'; | ||
import { getLocalStorageItem, removeLocalStorageItem } from 'utils/localStorage'; | ||
|
||
const GoogleOAuthRedirect = (): JSX.Element => { | ||
const history = useHistory(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
history 뭔가 오랜만에 보는 느낌 ㅋㅋㅋ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
구현 기능
Close #986