로딩에 대해서 선언적으로 리팩토링을 진행한다. #900
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
어떠한 문제를 해결하려고 했나요?
기존 error에 대해서는 ErrorBoundary를 이용하여 선언적으로 처리하고 있지만 로딩에 대해서는 선언적으로 처리하는 것이 없기에 추가해줘야 한다.
어떻게 문제를 해결하였나요?
react-query의
suspense: true옵션과 함께 Suspense를 이용하여 로딩에 대한 로직을 위임하였습니다.트러블 슈팅
기존 ErrorBoundary가 작동하지 않는 문제
ErrorBoundary를 이용하기 위해 useThrowCustomError를 이용하였는데 이것이
suspense: true와 함께할시 에러를 잡지 못하는 문제가 발생하였다.확인결과
suspense: true를 이용하면 useErrorBoundary가 저절로 true가 되어 생기는 문제였다. 현재 useErrorBoundary 옵션대신 useThrowCustomError로 처리하고 있기에 useErrorBoundary옵션을 false로 주어 해결하였습니다.