[FE] issue75: 이미지 에러 및 스터디 상세 페이지 수정 #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feat/75-no-image
open, close -> OPEN, CLOSE
스타일 컴포넌트 분리
… feat/75-no-image
nan-noo
added
🚀 feature
This was
linked to
issues
Jul 21, 2022
Closed
airman5573
reviewed
Jul 21, 2022
| { id: 2, tagName: 'JavaScript' }, | ||
| { id: 3, tagName: 'React' }, | ||
| { id: 4, tagName: 'Spring' }, | ||
| { id: 5, tagName: 'TypeScript' }, |
There was a problem hiding this comment.
Suggested change
| { id: 5, tagName: 'TypeScript' }, | |
| { id: 5, name: 'TypeScript' }, |
| <div className="tag-container"> | ||
| <S.TitleContainer> | ||
| <S.StudyTitle>{title}</S.StudyTitle> | ||
| <StudyChip isOpen={status === 'OPEN'} /> |
There was a problem hiding this comment.
Suggested change
| <StudyChip isOpen={status === 'OPEN'} /> | |
| <StudyChip isOpen={status === StudyStatus.OPEN} /> |
상수로 빼면 더 좋을것 같아요
| @@ -37,7 +38,7 @@ const App = () => { | |||
| <Route path="/" element={<MainPage />} /> | |||
| <Route path="/study/:studyId" element={<DetailPage />} /> | |||
There was a problem hiding this comment.
Suggested change
| <Route path="/study/:studyId" element={<DetailPage />} /> | |
| <Route path="ROUTE_PATHS.STUDY_DETAIL" element={<DetailPage />} /> |
상수로 분리하면 더 좋겠네요
| <span>시작일: {startDate}</span> ~ <span>종료일: {endDate || '없음'}</span> | ||
| </S.ExtraInfoContainer> | ||
| <S.Excerpt>"{excerpt}"</S.Excerpt> | ||
| <S.TagContainer> | ||
| {tags.map(({ id, tagName }) => ( |
There was a problem hiding this comment.
Suggested change
| {tags.map(({ id, tagName }) => ( | |
| {tags.map(({ id, name }) => ( |
| } | ||
| } | ||
| `} | ||
| export const Deadline = styled.p` |
There was a problem hiding this comment.
Suggested change
| export const Deadline = styled.p` | |
| export const EnrollmentEndDate = styled.p` |
| username, | ||
| profileImage, | ||
| studyCount = 12, | ||
| startDate = '2022-07-02', | ||
| startDate = '2022.07.02', |
There was a problem hiding this comment.
회의기록 : 2022-07-02대신 2022.07.02로 통일 (추후 전체 변경 예정)
| import Avatar from '@components/avatar/Avatar'; | ||
|
|
||
| import * as S from '@detail-page/components/study-member-card/StudyMemberCard.style'; | ||
|
|
||
| // TODO: studyCount, startDate api 명세에 필요 | ||
| export type StudyMemberCardProp = { | ||
| username: string; | ||
| profileImage: string; |
There was a problem hiding this comment.
Suggested change
| profileImage: string; | |
| imageUrl: string; |
일단 통일 하는게 좋겠네요
| <S.Title> | ||
| 스터디원 <span>{members.length}명</span> | ||
| </S.Title> | ||
| <S.MemberList> | ||
| {showAll | ||
| ? members.map(({ id, username, profileImage, profileUrl }) => ( |
There was a problem hiding this comment.
Suggested change
| ? members.map(({ id, username, profileImage, profileUrl }) => ( | |
| ? members.map(({ id, username, imageUrl, profileUrl }) => ( |
| font-size: 24px; | ||
| background: ${theme.colors.white}; | ||
| border: 3px solid ${theme.colors.primary.base}; | ||
| box-shadow: 8px 8px 0px ${theme.colors.secondary.dark}; |
There was a problem hiding this comment.
Suggested change
| box-shadow: 8px 8px 0px ${theme.colors.secondary.dark}; | |
| box-shadow: 8px 8px 0 ${theme.colors.secondary.dark}; | |
| ``` by. 병민 |
profileImage -> imageUrl tagName -> name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약
이미지 에러 발생시 처리
스터디 카드 스타일 수정
스터디 상세 페이지 스타일 및 컴포넌트 수정
변경된 api 명세에 맞게 수정
세부사항
close #75
close #82