[BE] issue129: 원하는 갯수만큼 작성된 후기 조회

backend/src/main/java/com/woowacourse/moamoa/common/advice/CommonControllerAdvice.java

@@ -1,15 +1,19 @@
 package com.woowacourse.moamoa.common.advice;
 
+import static org.springframework.http.HttpStatus.INTERNAL_SERVER_ERROR;
 import static org.springframework.http.HttpStatus.UNAUTHORIZED;
 
 import com.woowacourse.moamoa.common.advice.response.ErrorResponse;
 import com.woowacourse.moamoa.common.exception.InvalidFormatException;
 import com.woowacourse.moamoa.common.exception.UnauthorizedException;
 import com.woowacourse.moamoa.study.domain.exception.InvalidPeriodException;
 import com.woowacourse.moamoa.study.service.exception.FailureParticipationException;
+import org.springframework.http.HttpStatus;
 import org.springframework.http.ResponseEntity;
+import org.springframework.http.converter.HttpMessageNotReadableException;
 import org.springframework.web.bind.annotation.ExceptionHandler;
 import org.springframework.web.bind.annotation.RestControllerAdvice;
+import org.springframework.web.method.annotation.MethodArgumentTypeMismatchException;
 
 @RestControllerAdvice
 public class CommonControllerAdvice {
@@ -23,8 +27,22 @@ public ResponseEntity<ErrorResponse> handleBadRequest(final Exception e) {
         return ResponseEntity.badRequest().body(new ErrorResponse(e.getMessage()));
     }
 
+    @ExceptionHandler({
+            MethodArgumentTypeMismatchException.class,
+            HttpMessageNotReadableException.class
+    })
+    public ResponseEntity<ErrorResponse> handleBadRequest() {
+        return ResponseEntity.badRequest().body(new ErrorResponse("잘못된 요청 형식입니다."));
+    }
+
     @ExceptionHandler
     public ResponseEntity<Void> handleUnauthorized(final UnauthorizedException e) {
         return ResponseEntity.status(UNAUTHORIZED).build();
     }
+
+    @ExceptionHandler(RuntimeException.class)
+    public ResponseEntity<ErrorResponse> handleInternalServerError(RuntimeException e) {
+        e.printStackTrace();
+        return ResponseEntity.status(INTERNAL_SERVER_ERROR).body(new ErrorResponse("요청을 처리할 수 없습니다."));
+    }
 }

backend/src/main/java/com/woowacourse/moamoa/review/controller/ReviewController.java

@@ -1,6 +1,7 @@
 package com.woowacourse.moamoa.review.controller;
 
 import com.woowacourse.moamoa.review.service.ReviewService;
+import com.woowacourse.moamoa.review.service.request.SizeRequest;
 import com.woowacourse.moamoa.review.service.response.ReviewsResponse;
 import lombok.RequiredArgsConstructor;
 import org.springframework.http.ResponseEntity;
@@ -20,10 +21,9 @@ public class ReviewController {
     @GetMapping("/{study-id}/reviews")
     public ResponseEntity<ReviewsResponse> getReviews(
             @PathVariable(name = "study-id") Long studyId,
-            @RequestParam(required = false) Integer size
+            @RequestParam(name = "size", required = false, defaultValue = "") SizeRequest sizeRequest
     ) {
-        final ReviewsResponse reviewsResponse = reviewService.getReviewsByStudy(studyId, size);
-
+        final ReviewsResponse reviewsResponse = reviewService.getReviewsByStudy(studyId, sizeRequest);
         return ResponseEntity.ok(reviewsResponse);
     }
 }

backend/src/main/java/com/woowacourse/moamoa/review/controller/converter/SizeRequestConverter.java

@@ -0,0 +1,14 @@
+package com.woowacourse.moamoa.review.controller.converter;
+
+import com.woowacourse.moamoa.review.service.request.SizeRequest;
+import org.springframework.core.convert.converter.Converter;
+import org.springframework.stereotype.Component;
+
+@Component
+public class SizeRequestConverter implements Converter<String, SizeRequest> {
+
+    @Override
+    public SizeRequest convert(final String source) {
+        return source.isBlank() ? SizeRequest.empty() : new SizeRequest(Integer.parseInt(source));
+    }
+}

backend/src/main/java/com/woowacourse/moamoa/review/query/ReviewDao.java

@@ -0,0 +1,42 @@
+package com.woowacourse.moamoa.review.query;
+
+import com.woowacourse.moamoa.member.query.data.MemberData;
+import com.woowacourse.moamoa.review.query.data.ReviewData;
+import java.time.LocalDate;
+import java.util.List;
+import java.util.Map;
+import lombok.RequiredArgsConstructor;
+import org.springframework.jdbc.core.RowMapper;
+import org.springframework.jdbc.core.namedparam.NamedParameterJdbcTemplate;
+import org.springframework.stereotype.Repository;
+
+@Repository
+@RequiredArgsConstructor
+public class ReviewDao {
+
+    private final NamedParameterJdbcTemplate namedParameterJdbcTemplate;
+
+    public List<ReviewData> findAllByStudyId(final Long studyId) {
+        String sql = "SELECT review.id, review.content, review.created_date, review.last_modified_date, "
+                + "member.github_id, member.username, member.image_url, member.profile_url "
+                + "FROM review JOIN member ON review.member_id = member.id "
+                + "WHERE review.study_id = :studyId";
+
+        return namedParameterJdbcTemplate.query(sql, Map.of("studyId", studyId), rowMapper());
+    }
+
+    private RowMapper<ReviewData> rowMapper() {
+        return (rs, rn) -> {
+            final Long reviewId = rs.getLong("id");
+            final String content = rs.getString("content");
+            final LocalDate createdDate = rs.getObject("created_date", LocalDate.class);
+            final LocalDate lastModifiedDate = rs.getObject("last_modified_date", LocalDate.class);
+            final Long githubId = rs.getLong("github_id");
+            final String username = rs.getString("username");
+            final String imageUrl = rs.getString("image_url");
+            final String profileUrl = rs.getString("profile_url");
+            return new ReviewData(reviewId, new MemberData(githubId, username, imageUrl, profileUrl),
+                    createdDate, lastModifiedDate, content);
+        };
+    }
+}

backend/src/main/java/com/woowacourse/moamoa/review/query/data/ReviewData.java

@@ -0,0 +1,22 @@
+package com.woowacourse.moamoa.review.query.data;
+
+import com.woowacourse.moamoa.member.query.data.MemberData;
+import java.time.LocalDate;
+import lombok.AccessLevel;
+import lombok.AllArgsConstructor;
+import lombok.EqualsAndHashCode;
+import lombok.Getter;
+import lombok.NoArgsConstructor;
+
+@Getter
+@AllArgsConstructor
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
+@EqualsAndHashCode
+public class ReviewData {
+
+    private Long id;
+    private MemberData member;
+    private LocalDate createdDate;
+    private LocalDate lastModifiedDate;
+    private String content;
+}

backend/src/main/java/com/woowacourse/moamoa/review/service/ReviewService.java

@@ -1,11 +1,8 @@
 package com.woowacourse.moamoa.review.service;
 
-import static java.util.stream.Collectors.toList;
-
-import com.woowacourse.moamoa.review.domain.AssociatedStudy;
-import com.woowacourse.moamoa.review.domain.Review;
-import com.woowacourse.moamoa.review.domain.repository.ReviewRepository;
-import com.woowacourse.moamoa.review.service.response.ReviewResponse;
+import com.woowacourse.moamoa.review.query.ReviewDao;
+import com.woowacourse.moamoa.review.query.data.ReviewData;
+import com.woowacourse.moamoa.review.service.request.SizeRequest;
 import com.woowacourse.moamoa.review.service.response.ReviewsResponse;
 import java.util.List;
 import lombok.RequiredArgsConstructor;
@@ -17,25 +14,16 @@
 @RequiredArgsConstructor
 public class ReviewService {
 
-    private final ReviewRepository reviewRepository;
-
-    public ReviewsResponse getReviewsByStudy(Long studyId, Integer size) {
-        final AssociatedStudy associatedStudy = new AssociatedStudy(studyId);
+    private final ReviewDao reviewDao;
 
-        final List<Review> reviews = reviewRepository.findAllByAssociatedStudy(associatedStudy);
+    public ReviewsResponse getReviewsByStudy(Long studyId, SizeRequest sizeRequest) {
+        final List<ReviewData> allReviews = reviewDao.findAllByStudyId(studyId);
 
-        if (size != null) {
-            return makeReviewsResponse(reviews.subList(0, size), reviews.size());
+        if (sizeRequest.isEmpty() || sizeRequest.isMoreThan(allReviews.size())) {
+            return new ReviewsResponse(allReviews);
         }
 
-        return makeReviewsResponse(reviews, reviews.size());
+        return new ReviewsResponse(allReviews.subList(0, sizeRequest.getValue()), allReviews.size());
     }
 
-    private ReviewsResponse makeReviewsResponse(final List<Review> reviews, final int totalCount) {
-        final List<ReviewResponse> reviewResponses = reviews.stream()
-                .map(ReviewResponse::new)
-                .collect(toList());
-
-        return new ReviewsResponse(reviewResponses, totalCount);
-    }
 }

backend/src/main/java/com/woowacourse/moamoa/review/service/request/SizeRequest.java

@@ -0,0 +1,33 @@
+package com.woowacourse.moamoa.review.service.request;
+
+public class SizeRequest {
+
+    private final Integer value;
+
+    private SizeRequest() {
+        value = null;
+    }
+
+    public SizeRequest(final int value) {
+        this.value = value;
+    }
+
+    public Integer getValue() {
+        return value;
+    }
+
+    public boolean isEmpty() {
+        return value == null;
+    }
+
+    public boolean isMoreThan(int value) {
+        if (isEmpty()) {
+            throw new IllegalStateException("SizeRequest에 value가 null 입니다.");
+        }
+        return getValue() > value;
+    }
+
+    public static SizeRequest empty() {
+        return new SizeRequest();
+    }
+}

backend/src/main/java/com/woowacourse/moamoa/review/service/response/ReviewResponse.java

@@ -2,25 +2,30 @@
 
 import com.woowacourse.moamoa.member.query.data.MemberData;
 import com.woowacourse.moamoa.review.domain.Review;
+import com.woowacourse.moamoa.review.query.data.ReviewData;
+import java.time.LocalDate;
+import lombok.AccessLevel;
 import lombok.AllArgsConstructor;
+import lombok.EqualsAndHashCode;
 import lombok.Getter;
+import lombok.NoArgsConstructor;
+import lombok.ToString;
 
 @Getter
 @AllArgsConstructor
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
+@EqualsAndHashCode
+@ToString
 public class ReviewResponse {
 
     private Long id;
-    private MemberData member;
-    private String createdDate;
-    private String lastModifiedDate;
+    private WriterResponse member;
+    private LocalDate createdDate;
+    private LocalDate lastModifiedDate;
     private String content;
 
-    public ReviewResponse(Review review) {
-        this.id = review.getId();
-        this.member = new MemberData(review.getMember().getGithubId(), review.getMember().getUsername(),
-                review.getMember().getImageUrl(), review.getMember().getProfileUrl());
-        this.createdDate = review.getCreatedDate().toLocalDate().toString();
-        this.lastModifiedDate = review.getLastModifiedDate().toLocalDate().toString();
-        this.content = review.getContent();
+    public ReviewResponse(final ReviewData reviewData) {
+        this(reviewData.getId(), new WriterResponse(reviewData.getMember()), reviewData.getCreatedDate(),
+                reviewData.getLastModifiedDate(), reviewData.getContent());
     }
 }

backend/src/main/java/com/woowacourse/moamoa/review/service/response/ReviewsResponse.java

@@ -1,13 +1,31 @@
 package com.woowacourse.moamoa.review.service.response;
 
+import com.woowacourse.moamoa.review.query.data.ReviewData;
 import java.util.List;
+import java.util.stream.Collectors;
+import lombok.AccessLevel;
 import lombok.AllArgsConstructor;
 import lombok.Getter;
+import lombok.NoArgsConstructor;
 
 @Getter
-@AllArgsConstructor
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
 public class ReviewsResponse {
 
     private List<ReviewResponse> reviews;
     private Integer totalResults;
+
+    public ReviewsResponse(final List<ReviewData> reviews, final Integer totalResults) {
+        this.reviews = reviews.stream()
+                .map(ReviewResponse::new)
+                .collect(Collectors.toList());
+        this.totalResults = totalResults;
+    }
+
+    public ReviewsResponse(final List<ReviewData> reviews) {
+        this.reviews = reviews.stream()
+                .map(ReviewResponse::new)
+                .collect(Collectors.toList());
+        totalResults = reviews.size();
+    }
 }

backend/src/main/java/com/woowacourse/moamoa/review/service/response/WriterResponse.java

@@ -0,0 +1,29 @@
+package com.woowacourse.moamoa.review.service.response;
+
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.woowacourse.moamoa.member.query.data.MemberData;
+import lombok.AccessLevel;
+import lombok.AllArgsConstructor;
+import lombok.EqualsAndHashCode;
+import lombok.Getter;
+import lombok.NoArgsConstructor;
+
+@Getter
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
+@AllArgsConstructor
+@EqualsAndHashCode
+public class WriterResponse {
+
+    @JsonProperty("id")
+    private Long githubId;
+
+    private String username;
+
+    private String imageUrl;
+
+    private String profileUrl;
+
+    public WriterResponse(MemberData memberData) {
+        this(memberData.getGithubId(), memberData.getUsername(), memberData.getImageUrl(), memberData.getProfileUrl());
+    }
+}

backend/src/main/java/com/woowacourse/moamoa/tag/controller/SearchingTagController.java

@@ -1,5 +1,6 @@
 package com.woowacourse.moamoa.tag.controller;
 
+import com.woowacourse.moamoa.tag.query.request.CategoryIdRequest;
 import com.woowacourse.moamoa.tag.service.SearchingTagService;
 import com.woowacourse.moamoa.tag.service.response.TagsResponse;
 import java.util.Optional;
@@ -18,8 +19,8 @@ public class SearchingTagController {
     @GetMapping("/api/tags")
     public ResponseEntity<TagsResponse> searchTags(
             @RequestParam(value = "name", required = false, defaultValue = "") final String tagShortName,
-            @RequestParam(value = "category", required = false, defaultValue = "") final Optional<Long> categoryId) {
-        final TagsResponse tagsResponse = searchingTagService.getBy(tagShortName, categoryId);
+            @RequestParam(value = "category", required = false, defaultValue = "") final CategoryIdRequest categoryIdRequest) {
+        final TagsResponse tagsResponse = searchingTagService.getBy(tagShortName, categoryIdRequest);
         return ResponseEntity.ok().body(tagsResponse);
     }
 }

backend/src/main/java/com/woowacourse/moamoa/tag/controller/converter/CategoryIdConverter.java

@@ -1,14 +1,15 @@
 package com.woowacourse.moamoa.tag.controller.converter;
 
+import com.woowacourse.moamoa.tag.query.request.CategoryIdRequest;
 import java.util.Optional;
 import org.springframework.core.convert.converter.Converter;
 import org.springframework.stereotype.Component;
 
 @Component
-public class CategoryIdConverter implements Converter<String, Optional<Long>> {
+public class CategoryIdConverter implements Converter<String, CategoryIdRequest> {
 
     @Override
-    public Optional<Long> convert(final String source) {
-        return source.isBlank() ? Optional.empty() : Optional.of(Long.valueOf(source));
+    public CategoryIdRequest convert(final String source) {
+        return source.isBlank() ? CategoryIdRequest.empty() : new CategoryIdRequest(Long.parseLong(source));
     }
 }