Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] issue128: 전체적인 버그 및 기능 개선 #147

Merged
merged 15 commits into from
Jul 28, 2022
Merged

[FE] issue128: 전체적인 버그 및 기능 개선 #147

merged 15 commits into from
Jul 28, 2022

Conversation

nan-noo
Copy link
Collaborator

@nan-noo nan-noo commented Jul 28, 2022

요약

  • 반응형 UI 개선
  • 스터디 개설 폼 유효성 검증 개선: onChange 추가, 숫자 인풋

close #128

nan-noo and others added 13 commits July 26, 2022 14:41
@nan-noo
style: Main, Header, FilterSection 스타일 수정
71b78b4 
반응형 적용
@nan-noo
fix: 모킹서버핸들러 수정
43c5bd2
@nan-noo
feat: 헤더 검색시 메인페이지로 이동
2955227
@nan-noo
feat: FloatBox 스타일 및 로직 수정
7a37de5 
모집완료시 스타일 변경
@nan-noo
style: 버튼 폰트 크기 수정
8fcedfc
@nan-noo
refactor: path 상수 분리
cb74cf5
@nan-noo
refactor: prettier 적용
c69eaf5
@nan-noo
Merge branch 'develop' of https://github.com/nan-noo/2022-moamoa into…
6322f12 
… feat/128-sprint-make-up
@nan-noo @airman5573
fix: 폼 유효성 검증 오류 수정
41d15be 
Co-Authored-By: airman5573 <68623798+airman5573@users.noreply.github.com>
@nan-noo @airman5573
feat: 스터디 개설 입력값 유효성 검사 추가
ba6d3aa 
Co-Authored-By: airman5573 <68623798+airman5573@users.noreply.github.com>
@nan-noo @airman5573
feat: 숫자 인풋 수정
2430b78 
e, -, 한글 들어가지 않도록 수정

Co-Authored-By: airman5573 <68623798+airman5573@users.noreply.github.com>
@nan-noo @airman5573
fix: 스터디 개설 폼 submit 이벤트 에러 수정
bf08847 
Co-Authored-By: airman5573 <68623798+airman5573@users.noreply.github.com>
@nan-noo @airman5573
feat: localStorage -> sessionStorage로 변경
b17ba84 
Co-Authored-By: airman5573 <68623798+airman5573@users.noreply.github.com>
@nan-noo nan-noo added 🚀 feature New feature or request 😁 frontend New frontend feature 🛠 refactoring Refactor code labels Jul 28, 2022
@nan-noo nan-noo requested a review from airman5573 July 28, 2022 05:05
@nan-noo @airman5573
refactor: 상수 분리
b122a67 
Co-Authored-By: airman5573 <68623798+airman5573@users.noreply.github.com>
airman5573
airman5573 approved these changes Jul 28, 2022
View reviewed changes
Copy link
Collaborator

@airman5573 airman5573 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

frontend/src/App.tsx
<Routes>
<Route path="/" element={<MainPage />} />
<Route path="/study/:studyId" element={<DetailPage />} />
<Route path={PATH.MAIN} element={<MainPage />} />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

frontend/src/custom-types/index.ts
@@ -2,6 +2,12 @@ export type EmptyObject = Record<string, never>;

export type MakeOptional<T, K extends keyof T> = Omit<T, K> & Partial<Pick<T, K>>;

export type Required<T, K extends keyof T> = T & {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

frontend/src/hooks/useForm.tsx
@@ -63,14 +67,16 @@ export const makeValidationResult = (hasError: boolean, errorMessage?: string) =
errorMessage,
});

const initialFormState = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

frontend/src/pages/create-study-page/CreateStudyPage.tsx
@@ -46,7 +46,7 @@ const CreateStudyPage: React.FC = () => {
};
};

const onSubmit = async (event: React.FormEvent<HTMLFormElement>, submitResult: UseFormSubmitResult) => {
const onSubmit = async (_: React.FormEvent<HTMLFormElement>, submitResult: UseFormSubmitResult) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

frontend/src/pages/create-study-page/CreateStudyPage.tsx
@@ -78,19 +78,19 @@ const CreateStudyPage: React.FC = () => {
return mutateAsync(postData, {
onSuccess: () => {
alert('스터디를 생성했습니다');
window.location.href = '/';
navigate(PATH.MAIN);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

frontend/src/pages/create-study-page/components/category/Category.tsx
@@ -52,11 +52,11 @@ const Category = ({ className }: CategoryProps) => {
css={css`
margin-right: 10px;
`}
htmlFor="max-member-count"
htmlFor="generation"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

frontend/src/pages/create-study-page/components/enrollment-end-date/EnrollmentEndDate.tsx
@@ -24,7 +24,7 @@ const EnrollmentEndDate = ({ className }: PeriodProps) => {
<MetaBox.Content>
<div>
<label
htmlFor="state-date"
htmlFor="enrollment-end-date"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

frontend/src/pages/create-study-page/components/period/Peroid.tsx
@@ -28,7 +28,7 @@ const Period = ({ className }: PeriodProps) => {
`}
>
<label
htmlFor="state-date"
htmlFor="start-date"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

frontend/src/pages/create-study-page/components/tag/Tag.tsx
@@ -26,6 +26,7 @@ const Tag = ({ className }: TagProps) => {

return (
<select
id="tag-list"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tco0427
Copy link
Collaborator

tco0427 commented Jul 28, 2022

따봉 병민이네요!

@nan-noo @airman5573
refactor: 테마색으로 변경
db7136e 
Co-Authored-By: airman5573 <68623798+airman5573@users.noreply.github.com>
@nan-noo nan-noo merged commit 35507a5 into develop Jul 28, 2022
@nan-noo nan-noo deleted the feat/128-sprint-make-up branch July 28, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airman5573 airman5573 airman5573 approved these changes

Assignees

@nan-noo nan-noo

@airman5573 airman5573

Labels
🚀 feature New feature or request 😁 frontend New frontend feature 🛠 refactoring Refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nan-noo @tco0427 @airman5573