[BE] issue119: 내가 참여한 스터디 목록 조회 리팩터링 #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaejae-yoo
added
🐞 bug
tco0427
approved these changes
Aug 1, 2022
| @@ -35,11 +37,11 @@ public class MyStudyDao { | |||
| currentMemberCount, maxMemberCount, startDate, endDate); | |||
| }; | |||
|
|
|||
| private static final RowMapper<Map<Long, Map<MemberData, List<TagSummaryData>>>> OWNER_WITH_TAG_ROW_MAPPER = (rs, rn) -> { | |||
| Map<Long, Map<MemberData, List<TagSummaryData>>> result = new LinkedHashMap<>(); | |||
| private static final ResultSetExtractor<Map<Long, StudyOwnerWithTagsData>> OWNER_WITH_TAG_ROW_MAPPER = rs -> { | |||
There was a problem hiding this comment.
기존의 RowMapper 를 쓰면 첫번째 row 가 while (rs.next) 시 누락되어 ResultSetExtractor 로 변경해주셨군요..!!
굿굿👍
| } | ||
| return result; | ||
| }; | ||
|
|
||
| public List<MyStudySummaryData> findMyStudyByGithubId(Long id) { | ||
| String sql = "SELECT study.id, study.title, study.study_status, study.current_member_count, " | ||
| String sql = "SELECT DISTINCT study.id, study.title, study.study_status, study.current_member_count, " |
| public Map<Long, Map<MemberData, List<TagSummaryData>>> findStudyOwnerWithTags(List<Long> studyIds) { | ||
| public Map<Long, StudyOwnerWithTagsData> findStudyOwnerWithTags(List<Long> studyIds) { |
There was a problem hiding this comment.
이렇게 묶어준 게 훨씬 가독성 있는 것 같습니다!!
verus-j
requested changes
Aug 1, 2022
| @NoArgsConstructor | ||
| @AllArgsConstructor | ||
| @Getter | ||
| public class StudyOwnerWithTagsData { |
jaejae-yoo
force-pushed
the
refactoring/119-find-my-study
branch
from
748df68
to
441dcf1
Compare
verus-j
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약
내가 참여한 스터디 목록 기능을 리팩터링 및 누락된 요구사항을 추가한다.
세부사항
close #119