[FE] issue374: 버그 및 UI 개선 #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
스터디장이 자신이 만든 스터디를 클릭했을 때 alert를 띄운다.
태그가 많아질 경우 페이지를 넘어가는 경우가 발생 -> 페이지를 넘어가지 않도록 수정
라우팅할 때 relative 설정을 사용하기 위해 버전 업데이트
… feat/374-bug-and-ux
nan-noo
added
🐞 bug
airman5573
reviewed
Sep 28, 2022
frontend/src/pages/study-room-page/tabs/community-tab-panel/CommunityTabPanel.tsx
Show resolved
Hide resolved
...d/src/pages/study-room-page/tabs/community-tab-panel/components/article-list/ArticleList.tsx
Show resolved
Hide resolved
| ]; | ||
|
|
||
| const [activeTabId, setActiveTabId] = useState<TabId>(tabs[0].id); | ||
| const pathArr = location.pathname.split('/'); | ||
| const initialSelectedTabId = pathArr.length >= 4 ? pathArr[3] : tabs[0].id; |
There was a problem hiding this comment.
http://localhost:3000/studyroom/53172832/ 로했을때
pathArr가 ['', 'studyroom', '53172832', '']가 됩니다 !
그래서 pathArr[3] 이 빈 스트링이 되서 에러가 생깁니다!
|
|
||
| const activeTab = tabs.find(({ id }) => id === activeTabId) as Tab; | ||
|
|
||
| useEffect(() => { | ||
| const isFirstAccess = pathArr.length < 4; |
There was a problem hiding this comment.
4대신 조금 더 명확한 방법으로 체크 해주세요!
frontend/src/pages/study-room-page/tabs/community-tab-panel/components/article/Article.tsx
Show resolved
Hide resolved
frontend/src/pages/study-room-page/tabs/link-room-tab-panel/LinkRoomTabPanel.tsx
Show resolved
Hide resolved
- 스터디 방 페이지 인덱스로 접근시 notice page로 리다이렉트 - useEffect를 제거하고 App.tsx 라우팅으로 구현 - initialSelectedTabId + TabId 타입 좁히기
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약
#374 이 이슈 10가지 태스크 중 7가지를 수정했습니다.
스터디룸 페이지 라우팅을 기존의 객체를 사용하는 방식이 아니라, react-router의 nested routing을 적용하는 방향으로 수정했습니다.
세부사항
react-query caching
react-query 문서를 확인하니까 staleTime이 default 0이기 때문에 메모리에 캐싱되어 있어도 매번 다시 요청하고 있었습니다.
우선 링크 미리보기 useQuery에만 staleTime을 지정해보았더니 요청을 새로 보내지 않는 것을 확인했습니다.
전체적으로 staleTime을 지정할 필요가 있어 보입니다.
아직 수정하지 않은 부분
close #374