-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE] issue387: 서버 응답 런타임에 타입 확인 #401
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
아무 응답도 오지 않을 시 빈 string('')이 응답 데이터로 반환됨 -> 명시적으로 null로 교체
… feat/387-api-runtime-check
- 도메인에 맞게 이동
airman5573
requested changes
Oct 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
태태 코드 짜느라 수고하셨어요.
리뷰 확인해주세요 :D
- USER_ROLE - CATEGORY_NAME - STUDY_STATUS
isNullOrUndefined -> isNull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약
서버 응답이 타입대로 오지 않을 때 런타임 에러가 발생해서 화면이 하얗게 변하는 문제
-> axios api 응답값 반환 전에 타입을 체크해서 응답값이 제대로 오지 않을 시 처리를 통해 하얗게 변하는 것을 방지했습니다.
세부사항
api 폴더의 각 도메인마다 typeChecker.ts 파일을 추가했습니다.
예시
close #387