Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] issue50: 로그인 기능 구현 #76

Merged
merged 22 commits into from
Jul 19, 2022
Merged

[BE] issue50: 로그인 기능 구현 #76

merged 22 commits into from
Jul 19, 2022

Conversation

verus-j
Copy link
Collaborator

@verus-j verus-j commented Jul 18, 2022 •
edited
Loading

요약

로그인 기능을 구현한다.

세부사항

OAuth 2.0을 통해 로그인 기능을 구현한다.

  1. github client에게 ahtorization code를 받고, 이를 통해 access token을 요청한다.
  2. access token을 통해 사용자 profile 정보를 받는다.
  3. 받아 온 정보를 사용자 프로필 정보를 DB에 저장한다.
    • 존재하는 사용자면 정보를 update하고, 신규 사용자면 save한다.
  4. 사용자 정보(github id)를 사용하여 JWT를 발급한다.

구현하며 겪은 고민 공유
동작 흐름

close #50

jaejae-yoo and others added 17 commits July 13, 2022 15:20
@jaejae-yoo
test: OAuth 2.0 로그인 인수 테스트 작성
d0376f6
@jaejae-yoo
Merge branch 'develop' into feat/50-login
024e993
@jaejae-yoo
feat: Authorization code로 access_token 요청
029d384
@jaejae-yoo
fix: git 충돌 해결
d929038
@jaejae-yoo
feat: access_token으로 Github 사용자 프로필 요청
95062f2
@jaejae-yoo
feat: 사용자 정보 DB에 저장 및 업데이트
d5aa824
@jaejae-yoo
chore: jwt 라이브러리 추가
d1f0960
@jaejae-yoo
feat: github id로 JWT 발급
c88b27f
@jaejae-yoo
chore: yml 파일 설정
9d9e35d
@jaejae-yoo
Merge branch 'develop' into feat/50-login
ffd2dde
@sc0116
refactor: 롬복 적용
a7c524c
@sc0116
refactor: 테스트 파라미터 및 응답값 수정
8483ad5
@sc0116
refactor: RestTemplate AuthConfig로 이동
79d6908
@sc0116
test: JwtTokenProvider MockBean으로 변경
9620342
@sc0116
refactor: OAuthClient 인터페이스로 분리
983b0e9
@verus-j
chore: build.gradle에 테스트를 위한 프로퍼티 추가 설정
821b2d1
@verus-j
chore: build.gradle에서 주석 제거
918ded6
@verus-j verus-j changed the title Feat/50 login [BE] issue50: 로그인 기능 구현 Jul 18, 2022
@verus-j verus-j added 🚀 feature New feature or request 🖥 backend New backend feature labels Jul 18, 2022
@verus-j verus-j added this to the Milestone 2 milestone Jul 18, 2022
@verus-j verus-j requested a review from tco0427 July 18, 2022 16:42
tco0427
tco0427 approved these changes Jul 19, 2022
View reviewed changes
Copy link
Collaborator

@tco0427 tco0427 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좀 하네요..???😃

@jaejae-yoo jaejae-yoo merged commit d516a7b into develop Jul 19, 2022
@jaejae-yoo jaejae-yoo deleted the feat/50-login branch July 19, 2022 05:05
@jaejae-yoo jaejae-yoo restored the feat/50-login branch July 19, 2022 05:05
@jaejae-yoo jaejae-yoo deleted the feat/50-login branch July 19, 2022 05:05
@jaejae-yoo jaejae-yoo mentioned this pull request Jul 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tco0427 tco0427 tco0427 approved these changes

Assignees

@sc0116 sc0116

@jaejae-yoo jaejae-yoo

Labels
🖥 backend New backend feature 🚀 feature New feature or request
Projects
None yet
Milestone
Milestone 2
Development

Successfully merging this pull request may close these issues.
4 participants
@verus-j @tco0427 @sc0116 @jaejae-yoo