[FE] issue53: 디테일 페이지 구현 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oamoa into feat/53-detail-page
airman5573
added
🚀 feature
nan-noo
requested changes
Jul 19, 2022
| '@constants': resolve(__dirname, '../src/constants.ts'), | ||
| '@api': resolve(__dirname, '../src/api'), | ||
| '@context': resolve(__dirname, '../src/context'), | ||
| '@detail-page': resolve(__dirname, '../src/pages/detail-page'), |
There was a problem hiding this comment.
ㅇ여기에는 왜 main-page는 ㅇ없나요?!
그리고 pages가 있는데 그 내부 폴더들도 따로 만든 이유가 무엇인가요?
Comment on lines
+31
to
+32
| <Route path="/" element={<MainPage />} /> | ||
| <Route path="/study/:studyId" element={<DetailPage />} /> |
There was a problem hiding this comment.
예외 페이지 처리도 해주면 좋을 것 같네요!
path="*" element={<ErrorPage />}
There was a problem hiding this comment.
나중에 로그인/로그아웃 했을 때만 갈 수 있는 페이지도 처리합시당
frontend/src/api/getStudyDetail.ts
Outdated
| import axiosInstance from './axiosInstance'; | ||
|
|
||
| const getStudyDetail = async (studyId: string): Promise<{ study: StudyDetail }> => { | ||
| const response = await axiosInstance.get<{ study: StudyDetail }>(`/api/study/?study-id=${studyId}`); |
frontend/src/api/getStudyReviews.ts
Outdated
Comment on lines
10
to
12
| const getStudyReviews = async (studyId: string, size: number, loadAll: boolean): Promise<StudyReviewResponse> => { | ||
| const url = loadAll ? `/api/studies/${studyId}/review` : `/api/studies/${studyId}/review?size=${size}`; | ||
| const response = await axiosInstance.get<StudyReviewResponse>(url); |
There was a problem hiding this comment.
size를 옵셔널로 해서 구현하는 게 더 낫지 않을까요?
- size가 들어오면 일부, size가 없으면 전체
Comment on lines
+24
to
+26
| type DynamicImageContainerFn = (props: Pick<AvatarProps, 'size'>) => SerializedStyles; | ||
|
|
||
| const dynamicImageContainer: DynamicImageContainerFn = props => css` |
|
|
||
| const StudyReviewList: React.FC<{ reviews: Array<StudyReview> }> = ({ reviews }) => { | ||
| return ( | ||
| <div css={css``}> |
| currentMemberCount, | ||
| maxMemberCount, | ||
| owner, | ||
| onClickRegisterBtn, |
There was a problem hiding this comment.
애는 왜 handleRegisterButtonClick이 아닌가요?
| owner, | ||
| onClickRegisterBtn, | ||
| }) => { | ||
| const handleClickRegisterBtn = () => onClickRegisterBtn(studyId); |
| <S.StudyWideFloatBox> | ||
| <div className="left"> | ||
| <div className="deadline"> | ||
| <strong>{yyyymmddTommdd(deadline)}</strong> |
There was a problem hiding this comment.
이거 함수 네이밍이.. 흠 formatDate~~ 이런건 어떨까요
| return useQuery<{ study: StudyDetail }, unknown>([QK_FETCH_STUDY_DETAIL, studyId], () => getStudyDetail(studyId)); | ||
| }; | ||
|
|
||
| export default useFetchDetail; |
There was a problem hiding this comment.
요건 재활용 목적이 아닌 로직 분리를 위한 커스텀 훅인가요?
airman5573
force-pushed
the
feat/53-detail-page-2
branch
from
daa8ab1
to
ef28bb3
Compare
nan-noo
approved these changes
Jul 19, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약
디테일 페이지를 구현했습니다.
세부사항
등을 디테일 페이지에서 보여줍니다.
close #53