[FE] issue81: 로그인, 로그아웃 구현 #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
airman5573
approved these changes
Jul 20, 2022
| setIsLoggedIn: React.Dispatch<React.SetStateAction<boolean>>; | ||
| } | ||
|
|
||
| const hasAccessToken = !!window.localStorage.getItem('accessToken'); |
| }); | ||
|
|
||
| export const LoginProvider = ({ children }: LoginProviderProps) => { | ||
| const [isLoggedIn, setIsLoggedIn] = useState(hasAccessToken); |
There was a problem hiding this comment.
Suggested change
| const [isLoggedIn, setIsLoggedIn] = useState(hasAccessToken); | |
| const [isLoggedIn, setIsLoggedIn] = useState(() => !!window.localStorage.getItem('accessToken')); |
이런건 어떨까요? 보기가 좋아서요 ~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약
헤더에 로그인 및 로그아웃 버튼 구현
세부사항
추후 변경 가능 사항
나중에 MyPage 구현시 로그아웃 버튼을 페이지 내부로 옮길 예정
Avatar 정보를 서버에서 가져와야 함
주의사항: 추후 배포할 때 깃헙 OAuth에 등록한 콜백 URL이 바뀔 수 있음
close #81