Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

[BE] feat: 비지니스 로직과 DB(JPA) 로직을 분리하여 트랜잭션 적용범위 최소화 #403

Merged
merged 8 commits into from
Sep 14, 2023
Merged

[BE] feat: 비지니스 로직과 DB(JPA) 로직을 분리하여 트랜잭션 적용범위 최소화 #403

merged 8 commits into from
Sep 14, 2023

Conversation

ingpyo
Copy link
Collaborator

@ingpyo ingpyo commented Sep 13, 2023

🛠️ Issue

✅ Tasks

  • WritingService 트랜잭션 범위 최소화
  • pulishService 트랜잭션 범위 최소화
  • AuthService 트랜잭션 범위 최소화

⏰ Time Difference

  • 2

@ingpyo ingpyo added 🛠️ refactor 코드 리팩터링, 개선 🕋 backend 백엔드 작업 labels Sep 13, 2023
@ingpyo ingpyo added this to the 5차 데모데이 milestone Sep 13, 2023
@ingpyo ingpyo self-assigned this Sep 13, 2023
HubCreator
HubCreator approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@HubCreator HubCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앞단에 서비스 하나 더 두었군여ㅕ 고생하셨습니다

echo724
echo724 reviewed Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@echo724 echo724 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Facade 네이밍 좋네요~ 수고하셨으유~

backend/src/main/java/org/donggle/backend/application/service/MemberService.java Outdated
@@ -16,6 +16,7 @@
@Transactional
@RequiredArgsConstructor
public class MemberService {

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

개행 제거!

backend/src/main/java/org/donggle/backend/application/service/blog/PublishFacadeService.java Outdated
publishService.saveProperties(blog, writing, response);
}

private void checkWritingAlreadyPublished(final List<BlogWriting> publishedBlogs, final BlogType blogType, final Writing writing) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분은 크루들의 의견에 맡기겠습니다 ㅜ

@ingpyo ingpyo merged commit 7e66cd8 into develop Sep 14, 2023
@ingpyo ingpyo deleted the feature/transaction-range-change-402 branch September 14, 2023 07:04
echo724 pushed a commit that referenced this pull request Sep 22, 2023
@ingpyo
[BE] feat: 비지니스 로직과 DB(JPA) 로직을 분리하여 트랜잭션 적용범위 최소화 (#403)
2c17577 
* refactor: AuthService에 비지니스,DB로직 분리

* refactor: pulishService에 비지니스,DB로직 분리

* refactor: WritingService에 비지니스,DB로직 분리

* refactor: 패키지 이동

* refactor: 발행했는지 확인 로직 PublishService클래스로 이동

* refactor: Facade 클래스 네이밍 수정

* refactor: 검증로직 내부로 이동

* refactor: 개행 제거
echo724 pushed a commit that referenced this pull request Oct 6, 2023
@ingpyo
[BE] feat: 비지니스 로직과 DB(JPA) 로직을 분리하여 트랜잭션 적용범위 최소화 (#403)
45d0cfe 
* refactor: AuthService에 비지니스,DB로직 분리

* refactor: pulishService에 비지니스,DB로직 분리

* refactor: WritingService에 비지니스,DB로직 분리

* refactor: 패키지 이동

* refactor: 발행했는지 확인 로직 PublishService클래스로 이동

* refactor: Facade 클래스 네이밍 수정

* refactor: 검증로직 내부로 이동

* refactor: 개행 제거
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@echo724 echo724 echo724 approved these changes

@HubCreator HubCreator HubCreator approved these changes

@ezzanzzan ezzanzzan Awaiting requested review from ezzanzzan

Assignees

@ingpyo ingpyo

Labels
🕋 backend 백엔드 작업 🛠️ refactor 코드 리팩터링, 개선
Projects
2023-dong-gle
Status: Done
Milestone
5차 데모데이
Development

Successfully merging this pull request may close these issues.

비지니스 로직과 DB(JPA) 로직을 분리하여 트랜잭션 적용범위 최소화
3 participants
@ingpyo @HubCreator @echo724