Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

[FE] feat: 회원 탈퇴 기능 구현 #412

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

nangkyeonglim
Copy link
Collaborator

@nangkyeonglim nangkyeonglim commented Sep 14, 2023

🛠️ Issue

✅ Tasks

  • 회원 탈퇴 UI 구현
  • 회원 탈퇴 API mocking
  • 회원 탈퇴 API 연결

⏰ Time Difference

  • 0.5 -> 2

📝 Note

  • 탈퇴 시 한번 더 확인할 수 있는 모달을 추가했습니다.
  • 탈퇴 완료 시 accessToken을 지우고 introduce 페이지로 리다이렉트 시켰습니다.

@nangkyeonglim nangkyeonglim added 🎨 UI 디자인, UI 🖥️ frontend 프론트엔드 작업 🌟 feature 기능 추가 labels Sep 14, 2023
@nangkyeonglim nangkyeonglim self-assigned this Sep 14, 2023
@nangkyeonglim nangkyeonglim changed the title [FE] feat: 회원 탈퇴 기능 추가 [FE] feat: 회원 탈퇴 기능 구현 Sep 14, 2023
Copy link
Member

@jeonjeunghoon jeonjeunghoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이제 합법적인 서비스가 됐네요 ㅎㅎ
코멘트 남겼어요 확인 한 번 해주세요~

Comment on lines +11 to +20
return useMutation(deleteMemberAccount, {
onSuccess: () => {
localStorage.removeItem('accessToken');
goIntroducePage();
toast.show({ type: 'success', message: '탈퇴가 완료되었습니다.' });
},
onError: (error) => {
toast.show({ type: 'error', message: getErrorMessage(error) });
},
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mutate 를 따로 분리해서 리턴하지 않고 객체 자체를 리턴하신 이유는 mutate 이외에도 사용하는 프로퍼티가 있어서 그런가용?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 이제 공통으로 뺐으니까 다른 프로퍼티를 사용할 수도 있으니 바로 리턴하였습니다.
쿼리 훅 분리하면 다 이런식으로 바뀔 것 같아요~

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아하 그렇군요 이해했습니다~!

Copy link
Collaborator

@yogjin yogjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~

@nangkyeonglim nangkyeonglim merged commit 1cba8c8 into develop Sep 15, 2023
echo724 pushed a commit that referenced this pull request Sep 22, 2023
* feat: 회원 탈퇴 UI 구현

* feat: 탈퇴 API 작성

* feat: 탈퇴 API mocking

* feat: 탈퇴 API 연결
@echo724 echo724 deleted the feature/delete-account-388 branch October 6, 2023 05:21
echo724 pushed a commit that referenced this pull request Oct 6, 2023
* feat: 회원 탈퇴 UI 구현

* feat: 탈퇴 API 작성

* feat: 탈퇴 API mocking

* feat: 탈퇴 API 연결
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🌟 feature 기능 추가 🖥️ frontend 프론트엔드 작업 🎨 UI 디자인, UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

회원 탈퇴 기능 구현
3 participants