This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
[BE] refactor: logout 및 reissueRefreshToken 요청시 리프래시 토큰이 없는 경우 추가 핸들링 #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HubCreator
added
🐞 bug
HubCreator
changed the title
ezzanzzan
approved these changes
Oct 9, 2023
| @@ -25,7 +25,7 @@ public void addInterceptors(final InterceptorRegistry registry) { | |||
|
|
|||
| registry.addInterceptor(new AuthInterceptor(jwtTokenProvider)) | |||
| .addPathPatterns("/member/**", "/writings/**", "/categories/**", "/trash/**", "/connections/**", "/auth/**") | |||
| .excludePathPatterns("/connections/**/redirect", "/auth/login/**", "/auth/token/refresh") | |||
| .excludePathPatterns("/connections/**/redirect", "/auth/login/**", "/auth/token/refresh", "/auth/logout") | |||
There was a problem hiding this comment.
이제 확인했는데 여기 /connections/**/redirect면 tistory랑 notion도 해당될 거 같은데 이렇게 의도된게 맞나요 ?
There was a problem hiding this comment.
redirect할 때에 경로들인 것으로 확인했습니다. 해당 인터셉터는 AuthInterceptor로, AccessToken(JWT)를 확인하는 인터셉터이므로 빠진 제외시킨 것 같고, 문제 없을 것 같습니다!
ingpyo
approved these changes
Oct 9, 2023
Comment on lines
+82
to
89
| @Test | ||
| @DisplayName("쿠키에 리프레시 토큰이 없더라도, 로그아웃시 정상적으로 200 상태를 반환한다.") | ||
| void logout_without_refreshToken() throws Exception { | ||
| mockMvc.perform( | ||
| post("/auth/logout").contentType(MediaType.APPLICATION_JSON) | ||
|
|
||
| ) | ||
| .andExpect(status().isOk()); |
Comment on lines
74
to
76
| if (Objects.isNull(refreshToken)) { | ||
| throw new ExpiredRefreshTokenException(); | ||
| } |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Issue
✅ Tasks
⏰ Time Difference
📝 Note