Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE] Feature/#388 refresh token 및 로그아웃 기능 구현 #411
[BE] Feature/#388 refresh token 및 로그아웃 기능 구현 #411
Changes from all commits
51540a9
b6a1004
e0c399f
be4e868
91cb549
f083911
ed4834b
f74600a
50da580
d91e368
2ea1e6c
80db45f
edabfcd
d11c397
4fc08de
580b6b1
4236bd9
5a269ef
400309a
2697b7e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issueTokens() 랑 위치가 바뀌었으면 좋겠네요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issueTokens()
도 퍼블릭 메서드이고, LoginController에서 가장 먼저 사용하기 때문에 현재처럼 배치했습니당ㅋㅋThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
흠 그렇군요.
Token Service 만 봤을 때에는 reissueToken() 이 issueTokens() 메서드를 사용해서 헷갈렸던 것 같아요~
위와 같은 이유라면 현재 배치가 더 나을 것 같네용