[BE] Refactor/#547 로그인 회원 프로필 조회 API 명세 변경

backend/src/docs/asciidoc/member.adoc

@@ -4,9 +4,9 @@
 
 operation::member-controller-test/find-all-member[snippets='http-request,http-response']
 
-=== 회원 단일 조회
+=== 회원의 나의 프로필 조회
 
-operation::member-controller-test/find-member-by-id[snippets='http-request,http-response']
+operation::member-controller-test/find-my-profile[snippets='http-request,http-response']
 
 === 회원의 나의 지도 목록 조회
 

backend/src/main/java/com/mapbefine/mapbefine/member/application/MemberQueryService.java

@@ -9,7 +9,6 @@
 import com.mapbefine.mapbefine.member.dto.response.MemberDetailResponse;
 import com.mapbefine.mapbefine.member.dto.response.MemberResponse;
 import com.mapbefine.mapbefine.member.exception.MemberErrorCode;
-import com.mapbefine.mapbefine.member.exception.MemberException.MemberForbiddenException;
 import com.mapbefine.mapbefine.member.exception.MemberException.MemberNotFoundException;
 import com.mapbefine.mapbefine.pin.dto.response.PinResponse;
 import com.mapbefine.mapbefine.topic.domain.Topic;
@@ -41,12 +40,10 @@ public MemberQueryService(
         this.topicRepository = topicRepository;
     }
 
-    public MemberDetailResponse findById(AuthMember authMember, Long id) {
-        if (authMember.isSameMember(id)) {
-            Member member = findMemberById(id);
-            return MemberDetailResponse.from(member);
-        }
-        throw new MemberForbiddenException(MemberErrorCode.FORBIDDEN_ACCESS, id);
+    public MemberDetailResponse findMemberDetail(AuthMember authMember) {
+        Member member = findMemberById(authMember.getMemberId());
+
+        return MemberDetailResponse.from(member);
     }
 
     private Member findMemberById(Long id) {

backend/src/main/java/com/mapbefine/mapbefine/member/presentation/MemberController.java

@@ -13,7 +13,6 @@
 import org.springframework.http.ResponseEntity;
 import org.springframework.web.bind.annotation.GetMapping;
 import org.springframework.web.bind.annotation.PatchMapping;
-import org.springframework.web.bind.annotation.PathVariable;
 import org.springframework.web.bind.annotation.RequestBody;
 import org.springframework.web.bind.annotation.RequestMapping;
 import org.springframework.web.bind.annotation.RestController;
@@ -39,9 +38,9 @@ public ResponseEntity<List<MemberResponse>> findAllMember() {
     }
 
     @LoginRequired
-    @GetMapping("/{memberId}")
-    public ResponseEntity<MemberDetailResponse> findMemberById(AuthMember authMember, @PathVariable Long memberId) {
-        MemberDetailResponse response = memberQueryService.findById(authMember, memberId);
+    @GetMapping("/my/profiles")
+    public ResponseEntity<MemberDetailResponse> findMyProfile(AuthMember authMember) {
+        MemberDetailResponse response = memberQueryService.findMemberDetail(authMember);
 
         return ResponseEntity.ok(response);
     }

backend/src/test/java/com/mapbefine/mapbefine/member/MemberIntegrationTest.java

@@ -94,13 +94,13 @@ void findAllMember() {
     }
 
     @Test
-    @DisplayName("회원을 단일 조회한다.")
-    void findMemberById() {
+    @DisplayName("로그인 회원의 상세 정보를 단일 조회한다.")
+    void findMyProfile() {
         // given, when
         ExtractableResponse<Response> response = given().log().all()
                 .header(AUTHORIZATION, user1AuthHeader)
                 .contentType(MediaType.APPLICATION_JSON_VALUE)
-                .when().get("/members/" + user1.getId())
+                .when().get("/members/my/profiles")
                 .then().log().all()
                 .extract();
 
@@ -192,5 +192,5 @@ void updateMemberInfo_Success() {
         // then
         assertThat(response.statusCode()).isEqualTo(HttpStatus.OK.value());
     }
-    
+
 }

backend/src/test/java/com/mapbefine/mapbefine/member/application/MemberQueryServiceTest.java

@@ -8,6 +8,7 @@
 import com.mapbefine.mapbefine.atlas.domain.AtlasRepository;
 import com.mapbefine.mapbefine.auth.domain.AuthMember;
 import com.mapbefine.mapbefine.auth.domain.member.Admin;
+import com.mapbefine.mapbefine.auth.domain.member.User;
 import com.mapbefine.mapbefine.bookmark.domain.Bookmark;
 import com.mapbefine.mapbefine.bookmark.domain.BookmarkRepository;
 import com.mapbefine.mapbefine.common.annotation.ServiceTest;
@@ -20,7 +21,7 @@
 import com.mapbefine.mapbefine.member.domain.Role;
 import com.mapbefine.mapbefine.member.dto.response.MemberDetailResponse;
 import com.mapbefine.mapbefine.member.dto.response.MemberResponse;
-import com.mapbefine.mapbefine.member.exception.MemberException.MemberForbiddenException;
+import com.mapbefine.mapbefine.member.exception.MemberException.MemberNotFoundException;
 import com.mapbefine.mapbefine.pin.PinFixture;
 import com.mapbefine.mapbefine.pin.domain.Pin;
 import com.mapbefine.mapbefine.pin.domain.PinRepository;
@@ -29,6 +30,7 @@
 import com.mapbefine.mapbefine.topic.domain.Topic;
 import com.mapbefine.mapbefine.topic.domain.TopicRepository;
 import com.mapbefine.mapbefine.topic.dto.response.TopicResponse;
+import java.util.Collections;
 import java.util.List;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.DisplayName;
@@ -101,31 +103,26 @@ void findAllMember() {
     }
 
     @Test
-    @DisplayName("회원을 단일 조회한다.")
-    void findMemberById() {
+    @DisplayName("로그인 회원의 상세 정보를 조회한다.")
+    void findMyProfile() {
         // given
         // when
-        MemberDetailResponse response = memberQueryService.findById(authMember, member.getId());
+        MemberDetailResponse response = memberQueryService.findMemberDetail(authMember);
 
         // then
         assertThat(response).usingRecursiveComparison()
                 .isEqualTo(MemberDetailResponse.from(member));
     }
 
     @Test
-    @DisplayName("조회하려는 회원이 없는 경우 본인이 아니므로 예외를 반환한다.")
-    void findMemberById_whenNoneExists_thenFail() {
-        // given when then
-        assertThatThrownBy(() -> memberQueryService.findById(authMember, Long.MAX_VALUE))
-                .isInstanceOf(MemberForbiddenException.class);
-    }
+    @DisplayName("로그인한 식별값(ID)에 해당하는 회원 정보를 찾을 수 없는 경우 예외를 반환한다.")
+    void findMyProfile_whenNoneExists_thenFail() {
+        // given
+        AuthMember otherAuthMember = new User(Long.MAX_VALUE, Collections.emptyList(), Collections.emptyList());
 
-    @Test
-    @DisplayName("조회하려는 회원이 본인이 아닌 경우 예외를 반환한다.")
-    void findMemberById_whenNotSameMember_thenFail() {
-        // given when then
-        assertThatThrownBy(() -> memberQueryService.findById(authMember, Long.MAX_VALUE))
-                .isInstanceOf(MemberForbiddenException.class);
+        // when then
+        assertThatThrownBy(() -> memberQueryService.findMemberDetail(otherAuthMember))
+                .isInstanceOf(MemberNotFoundException.class);
     }
 
     @Test

backend/src/test/java/com/mapbefine/mapbefine/member/presentation/MemberControllerTest.java

@@ -48,8 +48,8 @@ void findAllMember() throws Exception {
     }
 
     @Test
-    @DisplayName("회원 단일 조회")
-    void findMemberById() throws Exception {
+    @DisplayName("회원 상세 정보 조회")
+    void findMyProfile() throws Exception {
         MemberDetailResponse memberDetailResponse = new MemberDetailResponse(
                 1L,
                 "member",
@@ -58,10 +58,10 @@ void findMemberById() throws Exception {
                 LocalDateTime.now()
         );
 
-        given(memberQueryService.findById(any(), any())).willReturn(memberDetailResponse);
+        given(memberQueryService.findMemberDetail(any())).willReturn(memberDetailResponse);
 
         mockMvc.perform(
-                MockMvcRequestBuilders.get("/members/1")
+                MockMvcRequestBuilders.get("/members/my/profiles")
                         .header(AUTHORIZATION, testAuthHeaderProvider.createAuthHeaderById(1L))
         ).andDo(restDocs.document());
     }