Feat/#176 Layout을 수정한다 (Header, layout color) #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creative-Lee
approved these changes
Aug 1, 2023
ukkodeveloper
approved these changes
Aug 2, 2023
| import { styled } from 'styled-components'; | ||
| import logo from '@/assets/icon/shook-logo.svg'; | ||
|
|
||
| const Header = () => { | ||
| return ( | ||
| <Container> | ||
| <Logo src={logo} alt="logo" /> | ||
| <Link to="/" aria-label="홈으로 가기"> |
There was a problem hiding this comment.
💬 "shook 홈으로 가기" 어떠신가요? 이부분은 웹접근성 회의 때 이야기해보아요.
| @@ -23,6 +23,7 @@ const LayoutContainer = styled.main` | |||
| padding: 60px 16.66%; | |||
| min-height: calc(100vh - ${({ theme }) => theme.headerHeight.desktop}); | |||
| background-color: ${({ theme: { color } }) => color.black}; | |||
| color: ${({ theme: { color } }) => color.white}; | |||
There was a problem hiding this comment.
누군가는 해야만 했던 일. 그걸 코난이 했습니다.
There was a problem hiding this comment.
💬 추후 고도화 사항으로 dark theme, light theme을 나누어야 하는 부분도 있는 것 같습니다..
background-color나 color는 Layout의 관리 영역이 아니라 theme의 관리 영역인 듯 싶어요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝작업 내용
/으로 가는 Link를 추가한다.💬리뷰 참고사항
현재 layout의 배경이 어두운 색이므로 기본 color를 white로 설정하였습니다.
#️⃣연관된 이슈
close #176