Feat/#377 가입하기 전 로그인 패널 페이지를 만들고, 로그인 버튼으로 대체 #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creative-Lee
approved these changes
Sep 10, 2023
frontend/src/pages/LoginPage.tsx
Outdated
| import { styled } from 'styled-components'; | ||
| import googleLogo from '@/assets/icon/google-logo.svg'; | ||
| import kakaoLogo from '@/assets/icon/kakao-logo.svg'; | ||
| import logo from '@/assets/icon/shook-logo.svg'; |
There was a problem hiding this comment.
💬 충돌 주의보 💬
💬제 PR에서 사라진 친구입니다💬
Comment on lines
+77
to
+80
| @supports (-webkit-appearance: none) and (stroke-color: transparent) { | ||
| min-height: -webkit-fill-available; | ||
| } | ||
| `; |
There was a problem hiding this comment.
💬 요거 사파리에서 네이티브 툴바가 화면 가리는 문제 해결하려고 사용하신 건가요~?
💬 support 조건이 -webkit-appearance stroke-color: transparent 인건 어떤 연관이 있나여~?
설명 한번 부탁드립니당~
There was a problem hiding this comment.
- @supports 주어진 하나 이상의 CSS 기능을 브라우저가 지원하는지에 따라 다른 스타일 선언을 할 수 있는 방법을 제공
- webkit-appearance: none): -webkit-appearance는 웹 요소의 기본 스타일을 제거하거나 변경하기 위한 것
이라고는 하는데 어떻게 safari만 적용되는지는 저도 잘 모르겠어용
| @@ -21,8 +19,8 @@ const Header = () => { | |||
| <ProfileAvatar src={shookshook} /> | |||
| </Link> | |||
| ) : ( | |||
| <Link to={googleAuthUrl}> | |||
| <ProfileAvatar src={defaultAvatar} /> | |||
| <Link to="/login"> | |||
There was a problem hiding this comment.
요거 상수로 살포시 빠지면 좋겠네요~ ㅎㅎ
There was a problem hiding this comment.
앗.. 상수로 빼놓고 적용을 안시켰네요.
✍️ 수정 커밋 - 3f4a351
ukkodeveloper
approved these changes
Sep 11, 2023
frontend/src/pages/LoginPage.tsx
Outdated
| `; | ||
|
|
||
| const KakaoLogin = styled(LoginButton)` | ||
| background-color: #fee500; |
There was a problem hiding this comment.
💬 저희 theme의 생상 팔레트에 없는 거 사용할 경우 일단 팔레트에 넣고 사용하는 거 어떨까요??? 다들 의견 궁금합니다.
There was a problem hiding this comment.
👍 theme으로 추출하였습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝작업 내용
로그인 버튼 변경
로그인 패널 페이지
💬리뷰 참고사항
카카오 로그인은 아직 구현되지 않았으므로 동작 안합니다.
일단 로그인 버튼 여러개일 경우 css 확인을 위해 넣었으며,
확인이 된 후에는 카카오 로그인 버튼을 빼도 될 것 같습니다.
#️⃣연관된 이슈
close #377