Refactor/#417 성능 개선을 위한 노래 데이터를 캐싱한다. #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seokhwan-an
added
[ 🌙 BE ]
세부사항 - cachedSong -> InMemorySongs으로 이름 변경 - util 클래스 -> repository 빈으로 수정
Cyma-s
approved these changes
Sep 20, 2023
|
|
||
| //when | ||
| //when인 |
| recreateCachedSong(); | ||
| } | ||
|
|
||
| @Scheduled(cron = "${schedules.in-memory-song.cron}") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝작업 내용
기존의 데이터베이스에서 불러오던 노래 데이터를 하루에 한번 캐싱하는 것으로 변경하여 캐싱된 데이터를 불러오도록 수정했습니다.
💬리뷰 참고사항
테스트는 추후 추가할 예정입니다.
기존에 구현되어 있던 SongServiceTest, ControllerTest 는 캐싱이 진행되도록 수정했습니다.
캐싱 데이터 갱신 시간은 security로 옮길 예정입니다.
#️⃣연관된 이슈