Refactor/#443 캐러셀 컴포넌트 및 썸네일 컴포넌트 리팩터링 #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukkodeveloper
requested review from
Creative-Lee and
cruelladevil
as code owners
ukkodeveloper
added
[ 🌞 FE ]
Creative-Lee
approved these changes
Sep 27, 2023
| @@ -91,3 +86,5 @@ const PlayingTime = styled.div` | |||
| const PlayingTimeText = styled.p` | |||
| padding-top: 2px; | |||
| `; | |||
|
|
|||
| const PlayIcon = styled.img``; | |||
There was a problem hiding this comment.
💬💬💬(매우 사소) width, height를 명시적으로 적어주는건 어떨까요?
There was a problem hiding this comment.
width와 height 명시해주었습니다.
| @@ -16,13 +17,13 @@ const CarouselItem = ({ votingSong }: CarouselItemProps) => { | |||
| return ( | |||
| <Wrapper> | |||
| <CollectingLink to={`${ROUTE_PATH.COLLECT}/${id}`}> | |||
| <Album src={albumCoverUrl} /> | |||
| <Thumbnail src={albumCoverUrl} size="xl" borderRadius={0} /> | |||
There was a problem hiding this comment.
💬💬💬(매우 사소) 아래 카테고리의 앨범 자켓 radius를 4px로 맞추는김에 통일 시켰었는데,
0px 인게 나으려나요?
There was a problem hiding this comment.
저도 동감합니다 border-radius: 4px에서 0으로 바뀐 이유가 있나용?
There was a problem hiding this comment.
기존 코드에서 0px이었기 때문에 Thumbnail에 borderRadius를 뚫어 놓고, 0px로 두었습니다. 기존 캐러셀 아이템을 만들 때 그렇게 정했던 이유은, 너무 같은 radius로만 표현하면 단조롭다고 생각해서였고요. 다들 통일감 있는 걸 선호하신다는 의견 반영해서 4px로 두겠습니다! 👍
cruelladevil
approved these changes
Sep 27, 2023
| @@ -16,13 +17,13 @@ const CarouselItem = ({ votingSong }: CarouselItemProps) => { | |||
| return ( | |||
| <Wrapper> | |||
| <CollectingLink to={`${ROUTE_PATH.COLLECT}/${id}`}> | |||
| <Album src={albumCoverUrl} /> | |||
| <Thumbnail src={albumCoverUrl} size="xl" borderRadius={0} /> | |||
There was a problem hiding this comment.
저도 동감합니다 border-radius: 4px에서 0으로 바뀐 이유가 있나용?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝작업 내용
#️⃣연관된 이슈
close #442 #443