Feat/#460 GA 이벤트 추가 #471
Merged
Feat/#460 GA 이벤트 추가 #471
+83
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukkodeveloper
requested review from
Creative-Lee and
cruelladevil
as code owners
ukkodeveloper
added
[ 🌞 FE ]
| sendGAEvent({ | ||
| action: 'click_copy', | ||
| category: 'song_playing', | ||
| memberId: user?.memberId, |
There was a problem hiding this comment.
user나 user.memberId가 없는 경우 어떻게 되나요?
There was a problem hiding this comment.
- 컴포넌트에서 user(전역 상태)를 사용하지 않는 경우 => 집계하지 않는다는 의미로 -2 플래그를 준다.
- 로그인이 되어있지 않는 유저 => -1 플래그를 준다
💬 이렇게 어떠신가요?
Creative-Lee
approved these changes
Sep 27, 2023
Comment on lines
53
to
58
| sendGAEvent({ | ||
| action: 'click_copy', | ||
| category: 'song_playing', | ||
| memberId: user?.memberId, | ||
| }); | ||
|
|
There was a problem hiding this comment.
action과 category도 기준을 정해서 상수화 하면 좋겠네요!
| if (isNowPlayingTrack) { | ||
| stopTrack(); | ||
| } else { | ||
| playTrack(); | ||
| } | ||
| }; | ||
|
|
||
| const onLikeButton = () => { |
There was a problem hiding this comment.
💬 요것도 네이밍을 likes 의 의미를 담아서 바꿔보면 좋을 것 같아요!
결정된 사항
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝작업 내용
작업내용
💬리뷰 참고사항
#️⃣연관된 이슈
close #460