Hotfix/#483 마이페이지에서 좋아요한 노래 아이템 클릭시 노래 듣기로 이동 #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukkodeveloper
requested review from
Creative-Lee and
cruelladevil
as code owners
| @@ -209,11 +211,15 @@ const LikePartItem = ({ songId, albumCoverUrl, title, singer, start, end }: Like | |||
| showToast('클립보드에 영상링크가 복사되었습니다.'); | |||
| }; | |||
|
|
|||
| const goToListenSong = () => { | |||
| navigate(`/songs/${songId}/ALL`); | |||
There was a problem hiding this comment.
💬 마이페이지에서 받아오는 api에서는 장르가 없군요..
ALL로 가면 백엔드에서 장르 섞어서 주도록 하나용?
There was a problem hiding this comment.
우선 급하게 진행된 것이라, 백엔드 요청 사항으로 ALL로 해달라고 하셨습니다.
나중에 고도화 진행하면, 장르도 필요 없을 것 같아요!
마이페이지에 있는 노래 목록으로 듣기 스와이프가 진행되어야하지 않을까요?
There was a problem hiding this comment.
마이페이지에 있는 노래 목록으로 듣기 스와이프가 진행되어야하지 않을까요?
별도의 페이지와 api가 있어야겠네요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝작업 내용
💬리뷰 참고사항
급하게 반영할 사항이라 merge 하겠습니다. 수정된 부분은 극히 적어요!
#️⃣연관된 이슈
close #483