Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/#518 frontend prod CD에 npm 캐시 추가 #520

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Conversation

cruelladevil
Copy link
Collaborator

📝작업 내용

이번 PR에서 작업한 내용을 간략히 설명(이미지 첨부 가능)

frontend prod CD에 npm 캐시 추가하였습니다.
CI에도 CD와 동일한 캐시 name, key, restore-key를 갖도록 수정하였습니다.

💬리뷰 참고사항

원활한 리뷰를 위해 전달하고 싶은 맥락(특정 파일, 디렉터리 등등)
리뷰어가 특별히 봐주었으면 하는 부분

image image

#️⃣연관된 이슈

연관된 이슈 번호를 모두 작성

close #518

@cruelladevil cruelladevil added 🔨 Refactor 꾸준한 개선이 더 나은 애플리케이션을 만든다 🤖 InfrA 인프라 관리도 잊지 말아요 🐈‍⬛ Github Github 는 우리의 친구 👯 labels Oct 18, 2023
@cruelladevil cruelladevil self-assigned this Oct 18, 2023
@cruelladevil cruelladevil merged commit 49b2472 into main Oct 18, 2023
@cruelladevil cruelladevil deleted the refactor/#518 branch October 18, 2023 13:11
@@ -10,26 +10,43 @@ jobs:

steps:
- name: Checkout Source Code
uses: actions/checkout@v2
uses: actions/checkout@v3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 캐시 디팬던시를 사용하려면 v3를 사용해야하나용?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인입니다

Comment on lines +30 to +33
restore-keys: |
${{ runner.os }}-node-${{ env.cache-name }}-
${{ runner.os }}-node-
${{ runner.os }}-
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 무슨역할인가용?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐈‍⬛ Github Github 는 우리의 친구 👯 🤖 InfrA 인프라 관리도 잊지 말아요 🔨 Refactor 꾸준한 개선이 더 나은 애플리케이션을 만든다
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[REFACTOR] 프론트엔드 CD에 패키지 캐싱을 추가한다.
2 participants