Skip to content

Commit

Permalink
fix: (#238) 카테고리 api 속성이 달라 발생하는 오류 수정
Browse files Browse the repository at this point in the history
- api 필드 isFavorite이 favorite으로 되어있었음
  • Loading branch information
chsua committed Aug 3, 2023
1 parent fe1a8e5 commit 04f6f87
Show file tree
Hide file tree
Showing 6 changed files with 26 additions and 27 deletions.
4 changes: 2 additions & 2 deletions frontend/__test__/api/categoryList.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ describe('카테고리에 대한 통신(카테고리 목록 조회, 즐겨찾기
});

test('회원이 카테고리 즐겨찾기를 할 수 있다.', async () => {
MOCK_CATEGORY_LIST[1].favorite = false;
MOCK_CATEGORY_LIST[1].isFavorite = false;

await addFavoriteCategory(MOCK_CATEGORY_LIST[1].id);

Expand All @@ -36,7 +36,7 @@ describe('카테고리에 대한 통신(카테고리 목록 조회, 즐겨찾기
});

test('회원이 카테고리 즐겨찾기를 해제할 수 있다.', async () => {
MOCK_CATEGORY_LIST[0].favorite = true;
MOCK_CATEGORY_LIST[0].isFavorite = true;

await removeFavoriteCategory(MOCK_CATEGORY_LIST[0].id);

Expand Down
2 changes: 1 addition & 1 deletion frontend/src/api/categoryList.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export const transformCategoryListResponse = (categoryList: CategoryResponse[])
return categoryList.map(category => ({
id: category.id,
name: category.name,
isFavorite: category.favorite,
isFavorite: category.isFavorite,
}));
};

Expand Down
4 changes: 2 additions & 2 deletions frontend/src/mocks/categoryList.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ export const mockCategoryHandlers = [
}),

rest.post('/categories/:categoryId/like', (req, res, ctx) => {
MOCK_CATEGORY_LIST[1].favorite = true;
MOCK_CATEGORY_LIST[1].isFavorite = true;

return res(ctx.status(201), ctx.json({ message: '카테고리 즐겨찾기 등록 성공' }));
}),

rest.delete('/categories/:categoryId/like', (req, res, ctx) => {
MOCK_CATEGORY_LIST[0].favorite = false;
MOCK_CATEGORY_LIST[0].isFavorite = false;

return res(ctx.status(204));
}),
Expand Down
40 changes: 20 additions & 20 deletions frontend/src/mocks/mockData/categoryList.ts
Original file line number Diff line number Diff line change
@@ -1,27 +1,27 @@
import { CategoryResponse } from '@type/category';

export const MOCK_CATEGORY_LIST: CategoryResponse[] = [
{ id: 1, name: '음식', favorite: false },
{ id: 2, name: '연애', favorite: true },
{ id: 3, name: '패션', favorite: false },
{ id: 4, name: '금융', favorite: false },
{ id: 5, name: '여행', favorite: false },
{ id: 6, name: '게임', favorite: false },
{ id: 7, name: '재테크', favorite: false },
{ id: 8, name: '요리', favorite: true },
{ id: 9, name: '개발', favorite: true },
{ id: 10, name: '전자기기', favorite: true },
{ id: 1, name: '음식', isFavorite: false },
{ id: 2, name: '연애', isFavorite: true },
{ id: 3, name: '패션', isFavorite: false },
{ id: 4, name: '금융', isFavorite: false },
{ id: 5, name: '여행', isFavorite: false },
{ id: 6, name: '게임', isFavorite: false },
{ id: 7, name: '재테크', isFavorite: false },
{ id: 8, name: '요리', isFavorite: true },
{ id: 9, name: '개발', isFavorite: true },
{ id: 10, name: '전자기기', isFavorite: true },
];

export const MOCK_GUEST_CATEGORY_LIST: CategoryResponse[] = [
{ id: 1, name: '음식', favorite: false },
{ id: 2, name: '연애', favorite: false },
{ id: 3, name: '패션', favorite: false },
{ id: 4, name: '금융', favorite: false },
{ id: 5, name: '여행', favorite: false },
{ id: 6, name: '게임', favorite: false },
{ id: 7, name: '재테크', favorite: false },
{ id: 8, name: '요리', favorite: false },
{ id: 9, name: '개발', favorite: false },
{ id: 10, name: '전자기기', favorite: false },
{ id: 1, name: '음식', isFavorite: false },
{ id: 2, name: '연애', isFavorite: false },
{ id: 3, name: '패션', isFavorite: false },
{ id: 4, name: '금융', isFavorite: false },
{ id: 5, name: '여행', isFavorite: false },
{ id: 6, name: '게임', isFavorite: false },
{ id: 7, name: '재테크', isFavorite: false },
{ id: 8, name: '요리', isFavorite: false },
{ id: 9, name: '개발', isFavorite: false },
{ id: 10, name: '전자기기', isFavorite: false },
];
2 changes: 1 addition & 1 deletion frontend/src/types/category.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ export interface Category {
export interface CategoryResponse {
id: number;
name: string;
favorite: boolean;
isFavorite: boolean;
}
1 change: 0 additions & 1 deletion frontend/src/utils/fetch.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ export const getFetch = async <T>(url: string): Promise<T> => {
}

const data = await response.json();

return data;
};

Expand Down

0 comments on commit 04f6f87

Please sign in to comment.