Skip to content

Commit

Permalink
refactor: (#746) repository 메서드명 수정
Browse files Browse the repository at this point in the history
  • Loading branch information
tjdtls690 committed Oct 17, 2023
1 parent 02717b9 commit 34a7350
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@

public interface ReportCustomRepository {

List<ReportAggregateDto> findReportsGroupedByMemberAndReportTypeAndTargetId(final Pageable pageable);
List<ReportAggregateDto> findReportsGroupedByReportTypeAndTargetId(final Pageable pageable);

}
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public class ReportCustomRepositoryImpl implements ReportCustomRepository {
private final JPAQueryFactory jpaQueryFactory;

@Override
public List<ReportAggregateDto> findReportsGroupedByMemberAndReportTypeAndTargetId(final Pageable pageable) {
public List<ReportAggregateDto> findReportsGroupedByReportTypeAndTargetId(final Pageable pageable) {
return jpaQueryFactory.select(
Projections.constructor(
ReportAggregateDto.class,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public ReportPageResponse getReports(final int page) {

final Pageable pageable = PageRequest.of(page, BASIC_PAGE_SIZE);
final List<ReportAggregateDto> reportAggregateDtos = reportRepository
.findReportsGroupedByMemberAndReportTypeAndTargetId(pageable);
.findReportsGroupedByReportTypeAndTargetId(pageable);
final List<ReportResponse> reportResponses = parseReportResponses(reportAggregateDtos);

return ReportPageResponse.of(totalPageNumber, page, reportResponses);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
import java.time.LocalDateTime;
import java.time.temporal.ChronoUnit;
import java.util.List;
import org.assertj.core.api.RecursiveComparisonAssert;
import org.assertj.core.api.SoftAssertions;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
Expand Down Expand Up @@ -67,7 +66,7 @@ void getReports() {

// when
final List<ReportAggregateDto> reports = reportCustomRepository
.findReportsGroupedByMemberAndReportTypeAndTargetId(pageRequest);
.findReportsGroupedByReportTypeAndTargetId(pageRequest);

// then
assertSoftly(softly -> {
Expand Down

0 comments on commit 34a7350

Please sign in to comment.