fix: (#346) 빈 이미지 처리 수정

woowacourse-teams · Aug 12, 2023 · 78c2432 · 78c2432
1 parent cb608ae
commit 78c2432
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 12 deletions.
diff --git a/backend/src/main/java/com/votogether/domain/post/dto/response/PostOptionResponse.java b/backend/src/main/java/com/votogether/domain/post/dto/response/PostOptionResponse.java
@@ -24,7 +24,7 @@ public static PostOptionResponse of(final Post post, final PostOption postOption
  }
 
  private static String convertImageUrl(final String imageUrl) {
- return imageUrl == null || imageUrl.contains("없는사진") ? "" : imageUrl;
+ return imageUrl == null ? "" : imageUrl;
  }
 
  public static PostOptionResponse of(

diff --git a/backend/src/main/java/com/votogether/domain/post/dto/response/PostResponse.java b/backend/src/main/java/com/votogether/domain/post/dto/response/PostResponse.java
@@ -57,7 +57,7 @@ public static PostResponse of(final Post post, final Member loginMember) {
  }
 
  private static String convertImageUrl(final String imageUrl) {
- return imageUrl == null || imageUrl.contains("없는사진") ? "" : imageUrl;
+ return imageUrl == null ? "" : imageUrl;
  }
 
  private static List<CategoryResponse> getCategories(final Post post) {

diff --git a/backend/src/main/java/com/votogether/domain/post/dto/response/detail/PostDetailResponse.java b/backend/src/main/java/com/votogether/domain/post/dto/response/detail/PostDetailResponse.java
@@ -42,7 +42,7 @@ public static PostDetailResponse of(final Post post, final Member loginMember) {
  WriterResponse.of(writer.getId(), writer.getNickname()),
  postBody.getTitle(),
  postBody.getContent(),
- convertImageUrl(contentImageUrl.toString()),
+ contentImageUrl.toString(),
  getCategories(postCategories.getPostCategories()),
  post.getCreatedAt(),
  post.getDeadline(),
@@ -54,10 +54,6 @@ public static PostDetailResponse of(final Post post, final Member loginMember) {
  );
  }
 
- private static String convertImageUrl(final String imageUrl) {
- return imageUrl.contains("없는사진") ? "" : imageUrl;
- }
-
  private static List<CategoryResponse> getCategories(final List<PostCategory> postCategories) {
  return postCategories.stream()
  .map(PostCategory::getCategory)

diff --git a/...rc/main/java/com/votogether/domain/post/dto/response/detail/PostOptionDetailResponse.java b/...rc/main/java/com/votogether/domain/post/dto/response/detail/PostOptionDetailResponse.java
@@ -18,14 +18,10 @@ public static PostOptionDetailResponse of(
  return new PostOptionDetailResponse(
  postOption.getId(),
  postOption.getContent(),
- convertImageUrl(postOption.getImageUrl()),
+ postOption.getImageUrl(),
  postOption.getVoteCount(isVisibleVoteResult),
  postOption.getVotePercent(totalVoteCount)
  );
  }
 
- private static String convertImageUrl(final String imageUrl) {
- return imageUrl.contains("없는사진") ? "" : imageUrl;
- }
-
 }