refactor: (#515) score 반환 long으로 변환

woowacourse-teams · Sep 6, 2023 · 9eba1d8 · 9eba1d8
1 parent f4c1261
commit 9eba1d8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/backend/src/main/java/com/votogether/domain/member/dto/response/RankingResponse.java b/backend/src/main/java/com/votogether/domain/member/dto/response/RankingResponse.java
@@ -17,7 +17,7 @@ public record RankingResponse(
  int voteCount,
 
  @Schema(description = "점수", example = "31")
- int score
+ long score
 ) {
 }
 
diff --git a/backend/src/main/java/com/votogether/domain/member/entity/vo/ActivityRecord.java b/backend/src/main/java/com/votogether/domain/member/entity/vo/ActivityRecord.java
@@ -16,7 +16,7 @@ public ActivityRecord(int postCount, int voteCount) {
  this.voteCount = voteCount;
  }
 
- public int calculateScore() {
+ public long calculateScore() {
  return postCount * POST_WEIGHT + voteCount * VOTE_WEIGHT;
  }
 

diff --git a/backend/src/main/java/com/votogether/domain/member/service/RankingBoard.java b/backend/src/main/java/com/votogether/domain/member/service/RankingBoard.java
@@ -2,6 +2,7 @@
 
 import com.votogether.domain.member.entity.Member;
 import com.votogether.domain.member.entity.vo.ActivityRecord;
+import java.util.Comparator;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -18,15 +19,15 @@ public RankingBoard(final Map<Member, ActivityRecord> passionBoard) {
 
  private void calculateRank() {
  final List<Member> members = passionBoard.entrySet().stream()
- .sorted((e1, e2) -> e2.getValue().calculateScore() - e1.getValue().calculateScore())
+ .sorted(Comparator.comparingLong(entry -> -entry.getValue().calculateScore()))
  .map(s -> s.getKey())
  .toList();
 
  int currentRanking = 1;
  int previousRanking = -1;
- int previousScore = -1;
+ long previousScore = -1;
  for (Member member : members) {
- int currentScore = passionBoard.get(member).calculateScore();
+ long currentScore = passionBoard.get(member).calculateScore();
  int ranking = (currentScore == previousScore) ? previousRanking : currentRanking;
 
  this.ranking.put(member, ranking);
@@ -37,7 +38,7 @@ private void calculateRank() {
  }
  }
 
- public int score(Member member) {
+ public long score(Member member) {
  return passionBoard.get(member).calculateScore();
  }