refactor: (#129) 멤버 닉네임 값 조회 타입 수정

woowacourse-teams · Jul 31, 2023 · d90b01f · d90b01f
1 parent e69419c
commit d90b01f
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 6 deletions.
diff --git a/backend/src/main/java/com/votogether/domain/auth/service/AuthService.java b/backend/src/main/java/com/votogether/domain/auth/service/AuthService.java
@@ -25,7 +25,7 @@ public LoginResponse register(final String code) {
  final Member member = Member.from(response);
  final Member registeredMember = memberService.register(member);
  final String token = tokenProcessor.generateToken(registeredMember);
- return new LoginResponse(token, registeredMember.getNickname().getValue());
+ return new LoginResponse(token, registeredMember.getNickname());
  }
 
 }
diff --git a/backend/src/main/java/com/votogether/domain/member/entity/Member.java b/backend/src/main/java/com/votogether/domain/member/entity/Member.java
@@ -91,4 +91,8 @@ public void changeNickname(final String nickname) {
  this.nickname = new Nickname(nickname);
  }
 
+ public String getNickname() {
+ return nickname.getValue();
+ }
+
 }
diff --git a/backend/src/main/java/com/votogether/domain/member/service/MemberService.java b/backend/src/main/java/com/votogether/domain/member/service/MemberService.java
@@ -43,7 +43,7 @@ public MemberInfoResponse findMemberInfo(final Member member) {
  final int numberOfVotes = voteRepository.countByMember(member);
 
  return new MemberInfoResponse(
- member.getNickname().getValue(),
+ member.getNickname(),
  member.getPoint(),
  numberOfPosts,
  numberOfVotes

diff --git a/backend/src/main/java/com/votogether/domain/post/dto/response/PostResponse.java b/backend/src/main/java/com/votogether/domain/post/dto/response/PostResponse.java
@@ -24,7 +24,7 @@ public static PostResponse of(final Post post, final Member loginMember) {
 
  return new PostResponse(
  post.getId(),
- WriterResponse.of(writer.getId(), writer.getNickname().getValue()),
+ WriterResponse.of(writer.getId(), writer.getNickname()),
  postBody.getTitle(),
  postBody.getContent(),
  getCategories(post),

diff --git a/backend/src/test/java/com/votogether/domain/member/repository/MemberRepositoryTest.java b/backend/src/test/java/com/votogether/domain/member/repository/MemberRepositoryTest.java
@@ -28,7 +28,7 @@ void ExistByNickname() {
  Member savedMember = memberRepository.save(MemberFixtures.MALE_20.get());
 
  // when
- boolean isExist = memberRepository.existsByNickname(savedMember.getNickname());
+ boolean isExist = memberRepository.existsByNickname(new Nickname(savedMember.getNickname()));
 
  // then
  assertThat(isExist).isTrue();

diff --git a/backend/src/test/java/com/votogether/domain/member/service/MemberServiceTest.java b/backend/src/test/java/com/votogether/domain/member/service/MemberServiceTest.java
@@ -52,7 +52,7 @@ void changeNickname() {
  memberService.changeNickname(member, newNickname);
 
  // then
- assertThat(member.getNickname().getValue()).isEqualTo(newNickname);
+ assertThat(member.getNickname()).isEqualTo(newNickname);
  }
 
  @ParameterizedTest
@@ -89,7 +89,7 @@ void changeNicknameEqualToPrevious() {
  Member member2 = memberRepository.save(MemberFixtures.MALE_30.get());
 
  // when, then
- assertThatThrownBy(() -> memberService.changeNickname(member1, member2.getNickname().getValue()))
+ assertThatThrownBy(() -> memberService.changeNickname(member1, member2.getNickname()))
  .isInstanceOf(BadRequestException.class)
  .hasMessage("이미 중복된 닉네임이 존재합니다.");
  }