-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
회원 닉네임 수정, 회원 탈퇴 fetch 함수 구현 및 MSW 코드 작성 #178
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
cbfa698
refactor: (#153) delete를 패치하는 함수 오류 제거를 위한 리팩터링
Gilpop8663 92e5375
feat: (#153): 유저 닉네임 변경, 회원 탈퇴 MSW 코드 작성
Gilpop8663 11eb7ce
feat: (#153) 유저 닉네임, 회원 탈퇴 api fetch 함수 구현
Gilpop8663 ff4090e
refactor: (#153) BASE_URL 추가 및 MSW 코드 성공했을 때 구체적인 메세지로 수정
Gilpop8663 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,17 +55,20 @@ export const putFetch = async <T, R>(url: string, body: T): Promise<R | void> => | |
return data; | ||
}; | ||
|
||
export const patchFetch = async (url: string) => { | ||
export const patchFetch = async <T>(url: string, body: T) => { | ||
const response = await fetch(url, { | ||
method: 'PATCH', | ||
headers, | ||
body: JSON.stringify(body), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍👍 |
||
}); | ||
|
||
const data = await response.json(); | ||
|
||
if (!response.ok) { | ||
throw new Error(data.message); | ||
} | ||
|
||
return response; | ||
}; | ||
|
||
export const deleteFetch = async (url: string) => { | ||
|
@@ -74,11 +77,7 @@ export const deleteFetch = async (url: string) => { | |
headers, | ||
}); | ||
|
||
const data = await response.json(); | ||
|
||
if (!response.ok) { | ||
throw new Error(data.message); | ||
} | ||
return response; | ||
}; | ||
|
||
export const multiPostFetch = async (url: string, body: FormData) => { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
닉네임이 성공적으로 수정되었습니다!
같은 구체적인 message 어떠신가요?!