-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
회원의 닉네임을 일정주기를 통해 변경할 수 있도록 구현 #498
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e89e99b
refactor: (#491) 닉네임 변경 주기 설정
jeomxon 04c3770
refactor: (#491) 닉네임 변경 주기에 대한 테스트하기 용이한 구조로 변경 및 도메인 테스트 추가
jeomxon 7fb38cd
refactor: (#491) 불필요한 출력문 제거
jeomxon ea5a55f
test: (#491) 리플렉션 유틸 클래스를 사용하도록 변경
jeomxon bb5899c
refactor: (#491) 닉네임 최초 변경 로직을 prefix로 구분하도록 변경
jeomxon db6fd73
refactor: (#491) 닉네임 변경 메서드 분리 및 예외 메시지 수정
jeomxon 47d8ea7
test: (#491) 초기 닉네임이 포함되었을 때 닉네임이 변경되지 않도록 확인하는 검증 추가
jeomxon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
115 changes: 115 additions & 0 deletions
115
backend/src/test/java/com/votogether/domain/member/entity/MemberTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,115 @@ | ||
package com.votogether.domain.member.entity; | ||
|
||
import static org.assertj.core.api.Assertions.assertThat; | ||
import static org.assertj.core.api.Assertions.assertThatThrownBy; | ||
|
||
import com.votogether.domain.member.entity.vo.Gender; | ||
import com.votogether.domain.member.entity.vo.SocialType; | ||
import com.votogether.global.exception.BadRequestException; | ||
import java.time.LocalDateTime; | ||
import org.junit.jupiter.api.DisplayName; | ||
import org.junit.jupiter.api.Nested; | ||
import org.junit.jupiter.api.Test; | ||
import org.springframework.test.util.ReflectionTestUtils; | ||
|
||
class MemberTest { | ||
|
||
@Nested | ||
@DisplayName("닉네임을 주기에 따라 변경하는 경우") | ||
class ChangeNicknameByCycle { | ||
|
||
@Test | ||
@DisplayName("15일전에 변경된 닉네임은 14일 주기로 변경할 때 성공적으로 변경된다.") | ||
void success() { | ||
// given | ||
Member member = Member.builder() | ||
.nickname("저문") | ||
.gender(Gender.MALE) | ||
.birthYear(1966) | ||
.socialId("abc123") | ||
.socialType(SocialType.KAKAO) | ||
.build(); | ||
|
||
LocalDateTime now = LocalDateTime.now().minusDays(15L); | ||
ReflectionTestUtils.setField(member, "createdAt", now); | ||
ReflectionTestUtils.setField(member, "updatedAt", now.plusHours(1L)); | ||
|
||
// when | ||
member.changeNicknameByCycle("저라니", 14L); | ||
|
||
// then | ||
assertThat(member.getNickname()).isEqualTo("저라니"); | ||
} | ||
|
||
@Test | ||
@DisplayName("13일 전에 변경된 닉네임은 14일 주기로 변경하더라도 한번도 닉네임을 변경하지 않았다면 성공적으로 변경된다.") | ||
void successFirstChange() { | ||
// given | ||
Member member = Member.builder() | ||
.nickname("익명의손님fFp4vAgX2d") | ||
.gender(Gender.MALE) | ||
.birthYear(1966) | ||
.socialId("abc123") | ||
.socialType(SocialType.KAKAO) | ||
.build(); | ||
|
||
LocalDateTime now = LocalDateTime.now().minusDays(13L); | ||
ReflectionTestUtils.setField(member, "createdAt", now); | ||
ReflectionTestUtils.setField(member, "updatedAt", now.plusHours(1L)); | ||
|
||
// when | ||
member.changeNicknameByCycle("저라니", 14L); | ||
|
||
// then | ||
assertThat(member.getNickname()).isEqualTo("저라니"); | ||
} | ||
|
||
@Test | ||
@DisplayName("13일 전에 변경된 닉네임은 14일 주기로 변경할 때 변경에 실패한다.") | ||
void fail() { | ||
// given | ||
Member member = Member.builder() | ||
.nickname("저문") | ||
.gender(Gender.MALE) | ||
.birthYear(1966) | ||
.socialId("abc123") | ||
.socialType(SocialType.KAKAO) | ||
.build(); | ||
|
||
LocalDateTime createdTime = LocalDateTime.now().minusDays(20L); | ||
LocalDateTime updatedTime = LocalDateTime.now().minusDays(13L); | ||
ReflectionTestUtils.setField(member, "createdAt", createdTime); | ||
ReflectionTestUtils.setField(member, "updatedAt", updatedTime); | ||
|
||
// when, then | ||
assertThatThrownBy(() -> member.changeNicknameByCycle("저라니", 14L)) | ||
.isInstanceOf(BadRequestException.class) | ||
.hasMessage("최소 닉네임 변경주기가 지나지 않았습니다."); | ||
} | ||
|
||
@Test | ||
@DisplayName("초기 닉네임의 접두사가 포함되어 있으면 예외가 발생한다.") | ||
void notAllowedChangeToInitialNicknamePrefix() { | ||
// given | ||
Member member = Member.builder() | ||
.nickname("저문") | ||
.gender(Gender.MALE) | ||
.birthYear(1966) | ||
.socialId("abc123") | ||
.socialType(SocialType.KAKAO) | ||
.build(); | ||
|
||
LocalDateTime createdTime = LocalDateTime.now().minusDays(20L); | ||
LocalDateTime updatedTime = LocalDateTime.now().minusDays(7L); | ||
ReflectionTestUtils.setField(member, "createdAt", createdTime); | ||
ReflectionTestUtils.setField(member, "updatedAt", updatedTime); | ||
|
||
// when, then | ||
assertThatThrownBy(() -> member.changeNicknameByCycle("익명의손님저라니", 14L)) | ||
.isInstanceOf(BadRequestException.class) | ||
.hasMessage("초기 닉네임에 포함된 접두어로 닉네임을 변경할 수 없습니다."); | ||
} | ||
|
||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
닉네임 변경 이후 14일이 지나면 닉네임이 변경가능한지 여부도 테스트해볼 수 없을까요? 😎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
한번 작성해보겠습니다..!