Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cookie의 path를 /auth에서 /로 변경 및 RefreshToken TTL설정 #610

Merged
merged 2 commits into from
Sep 14, 2023
Merged

cookie의 path를 /auth에서 /로 변경 및 RefreshToken TTL설정 #610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2922814
refactor: (#608) cookie의 path를 루트 경로로 지정
jeomxon Sep 13, 2023
6b31325
refactor: (#608) refreshtoken을 redis에 저장할 때 ttl설정
jeomxon Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions backend/src/main/java/com/votogether/domain/auth/controller/AuthController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ private void addRefreshTokenToCookie(final HttpServletResponse httpServletRespon
final ResponseCookie responseCookie = ResponseCookie.from("refreshToken", refreshToken)
.httpOnly(true)
.secure(true)
.path("/auth")
.path("/")
.maxAge(1209600)
.sameSite(SameSite.NONE.attributeValue())
.build();
Expand All @@ -94,7 +94,7 @@ private void expireCookie(final HttpServletResponse httpServletResponse, final S
final ResponseCookie responseCookie = ResponseCookie.from("refreshToken", refreshToken)
.httpOnly(true)
.secure(true)
.path("/auth")
.path("/")
.maxAge(0)
.sameSite(SameSite.NONE.attributeValue())
.build();
Expand Down
3 changes: 2 additions & 1 deletion backend/src/main/java/com/votogether/domain/auth/service/AuthService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import com.votogether.global.jwt.TokenPayload;
import com.votogether.global.jwt.TokenProcessor;
import com.votogether.global.jwt.exception.JsonException;
import java.time.Duration;
import java.util.Objects;
import lombok.RequiredArgsConstructor;
import org.springframework.data.redis.core.RedisTemplate;
Expand Down Expand Up @@ -58,7 +59,7 @@ public ReissuedTokenDto reissueAuthToken(

final String newAccessToken = tokenProcessor.generateAccessToken(accessTokenPayload.memberId());
final String newRefreshToken = tokenProcessor.generateRefreshToken(accessTokenPayload.memberId());
redisTemplate.opsForValue().set(newRefreshToken, accessTokenPayload.memberId());
redisTemplate.opsForValue().set(newRefreshToken, accessTokenPayload.memberId(), Duration.ofDays(14L));
return new ReissuedTokenDto(newAccessToken, newRefreshToken);
}

Expand Down