-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
성능 최적화를 위한 리액트 쿼리 캐시정책 설정 및 불필요한 fetch하지 않기 #626
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
ddc6b8b
chore: (#619) 리액트 쿼리 캐싱 확인을 위한 세팅
chsua adfd841
feat: (#619) 마감된 게시물 상세정보 1시간 캐싱하기
chsua 88dea16
design: 에러 메세지 컴포넌트 어절 단위로 개행 및 상하 마진 수정
chsua 891cb8f
feat: (#619) 통계 서버데이터 형식을 사용처가 아닌 불러오는 곳에서 형식 변경
chsua 20ca82a
feat: (#619) 통계 페이지 리액트 쿼리로 수정 및 서스펜스, 에러바운더리 적용
chsua 3c00764
fix: 통계 api msw에서 실서버로 요청 전환
chsua 8a8506c
fix: thead, tbody가 없어서 발생하는 에러 해결
chsua e218541
Merge branch 'dev' into feat/#619
chsua e39f5c3
fix: (#627) 개발서버 오리진 url 수정 (#628)
aiaiaiai1 4e9d264
style: (#622) 선택지가 왼쪽으로 움직이는 버그 수정
Gilpop8663 4081b70
fix: (#629) https 로컬호스트 오리진 url 추가 (#630)
aiaiaiai1 65f999e
feat: (#602) 본문 이미지를 붙여넣기 이벤트로 이미지를 첨부할 수 있도록 구현
Gilpop8663 4693eea
refactor: (#602) 선택지 작성에서 중복되는 업로드 이미지 코드를 리팩터링한 것을 적용
Gilpop8663 2b8b602
refactor: (#602) 사용하지 않는 async 제거, 부자연스러운 함수명 변경
Gilpop8663 71a3830
refactor: (#619) 불분명한 변수명 수정
chsua 8af09a4
feat: 열정유저 테이블 내 2개의 api 중 하나라도 로딩/에러 시 테이블 폴백처리
chsua 8e9883b
refactor: (#619) 사용하지 않는 useFetch 삭제
chsua 238562d
feat: (#619) 통계 페이지 에러바운더리/ 서스펜스 범위 수정
chsua 856ef74
refactor: (#619) 서스펜스, 에러바운더리 감싸는 순서를 기존 코드와 통일
chsua f5e4a2b
feat: 리액트 쿼리 데브 툴 설정
chsua File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 운영(prod) 환경에서는 필요 없을거 같아요! msw처럼 dev에서만 작동하도록 하는거 어떨까요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can import the devtools like this:
tsx
import { ReactQueryDevtools } from '@tanstack/react-query-devtools'
By default, React Query Devtools are only included in bundles when process.env.NODE_ENV === 'development', so you don't need to worry about excluding them during a production build.
기본적으로 개발환경에서만 번들에 포함되서 빌드된대요
tsx
'@tanstack/react-query-devtools'에서 {ReactQueryDevtools} 가져오기
기본적으로 React Query Devtools는 process.env.Node_ENV === 'development'일 때 번들에만 포함되므로 프로덕션 빌드 시 제외할 걱정이 없습니다.
근데 import만 하고 ReactQueryDevtools가 작성된 곳은 보이지 않는데 확인해주실수 있으실까요?
https://tanstack.com/query/v4/docs/react/devtools#install-and-import-the-devtools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
지금 로컬이랑 비교해보았는데
기본적으로 개발환경에서만 번들에 포함되서 빌드된대요
라고 말씀 주셨던 것처럼 로컬에는 작성되어있는데 깃허브로 올라오면서 삭제되나봐요😅