Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

선택지에서 이미지 붙혀넣기로 업로드 가능하도록 구현 #698

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

Gilpop8663
Copy link
Collaborator

@Gilpop8663 Gilpop8663 commented Oct 2, 2023

🔥 연관 이슈

close: #675

📝 작업 요약

  • 선택지에서 이미지 붙혀넣기로 업로드 가능하도록 구현

⏰ 소요 시간

30분

🔎 작업 상세 설명

전에 만들어 놓은 메서드를 활용해서 붙혀넣기를 가능하게 했음

  const setPreviewImageUrl = (optionId: number) => (imageUrl: string) => {
    const updatedOptionList = optionList.map(optionItem => {
      if (optionItem.id === optionId) {
        return { ...optionItem, imageUrl };
      }

      return optionItem;
    });

    setOptionList(updatedOptionList);
  };

🌟 논의 사항

크루들과 이야기 해보고 싶은 부분을 적어주세요.

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

⚡️ Lighthouse report!

Category Score
🟠 Performance 71
🟠 Accessibilty 89
🟢 SEO 100
🟠 PWA 89
Category Score
🟢 First Contentful Paint 0.7 s
🟠 Largest Contentful Paint 2.8 s
🔴 Total Blocking Time 1,280 ms
🟢 Cumulative Layout Shift 0
🟢 Speed Index 2.8 s

Copy link
Collaborator

@chsua chsua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추석인데도 열일하시는군요 우스!
본문과 선택지의 기능을 동일하게 가지고 가는 것 너무 좋아요!
앞서 본문 사진 붙여넣기와 동일한 부분이 많아서 코멘트할 부분은 따로 없네요
고생하셨습니다!

Copy link
Member

@inyeong-kang inyeong-kang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이미지 다운로드했다가 업로드하기 귀찮았는데 덕분에 사용성이 훨씬 개선되었네요👍👍

@inyeong-kang inyeong-kang merged commit fbf6edf into dev Oct 4, 2023
2 checks passed
@inyeong-kang inyeong-kang deleted the feat/#675 branch October 4, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

선택지 옵션에서 이미지 복사 붙혀넣기 가능하도록 구현
3 participants