Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cmd(Ctrl) + Enter를 입력했을 때 댓글이 작성되도록 구현 #736

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Cmd(Ctrl) + Enter를 입력했을 때 댓글이 작성되도록 구현 #736

merged 5 commits into from
Oct 13, 2023

Conversation

Gilpop8663
Copy link
Collaborator

🔥 연관 이슈

close: #732

📝 작업 요약

  • Cmd(Ctrl) + Enter를 입력했을 때 댓글이 작성되도록 구현

⏰ 소요 시간

10분

🔎 작업 상세 설명

  • Ctrl + Enter를 입력했을 때 댓글이 작성되도록 구현
  • Cmd + Enter가 되는 지는 캠퍼스의 맥북을 이용해서 테스트해봐야될 것 같음
  • KeyboardEvent의 event.ctrlKey , event.code을 통해서 구현

@Gilpop8663 Gilpop8663 self-assigned this Oct 11, 2023
@github-actions
Copy link

github-actions bot commented Oct 11, 2023 •
edited
Loading

⚡️ Lighthouse report!

Category Score
🟠 Performance 70
🟠 Accessibilty 89
🟢 SEO 100
🟠 PWA 89
Category Score
🟢 First Contentful Paint 0.6 s
🟠 Largest Contentful Paint 2.9 s
🔴 Total Blocking Time 1,430 ms
🟢 Cumulative Layout Shift 0
🟢 Speed Index 2.5 s

inyeong-kang
inyeong-kang approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@inyeong-kang inyeong-kang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 이 부분 살짝 불편했는데 개선해주셔서 감사합니다👍👍
혹시 슬랙처럼 어떻게 댓글을 저장할 수 있는지 안내문구를 적어주는 것은 어떨까요??
예를 들어 Ctrl+Enter 키로 댓글을 저장할 수 있습니다
image

@inyeong-kang
Copy link
Member

fe-리뷰완

@Gilpop8663
Copy link
Collaborator Author

맥북에서 안되길래 command 키를 추가했습니다 그리고 제로가 제안해주신대로 설명을 밑에 붙혀보았습니다

스크린샷 2023-10-12 오후 1 54 48 image

fe-리뷰요청

@Gilpop8663
Copy link
Collaborator Author

글자 크기 줄여보았어요~!
모바일 12px
pc 14px

image image

fe-리뷰요청

chsua
chsua approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@chsua chsua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

호옥시 디자인적으로 요청사항이 있는데 수정해주실 수 있으신가요??
사소한 부분이라 일단 approve하겠습니다!

fe-리뷰완

frontend/src/components/comment/CommentList/CommentTextForm/index.tsx Outdated
@@ -118,6 +127,7 @@ export default function CommentTextForm({
</SquareButton>
</S.ButtonWrapper>
</S.ButtonContainer>
<S.KeyDescription>Ctrl(Command) + Enter 키로 댓글을 저장할 수 있습니다</S.KeyDescription>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 부분 버튼 위로 올려주실 수 있으신가요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수아의 제안대로 적용해보았어요 👍

image

frontend/src/components/comment/CommentList/CommentTextForm/style.ts
@@ -20,12 +20,12 @@ export const TextArea = styled.textarea`
resize: none;

&::placeholder {
font-size: 14px;
font-size: 1.4rem;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

옹 요거 var(--)로 하지 않으신 이유가 있나요?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 1.4rem을 가진 --가 없군요 ;;

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 맞습니당 😃

@Gilpop8663
Copy link
Collaborator Author

fe-리뷰요청

@Gilpop8663 Gilpop8663 merged commit e6661b4 into dev Oct 13, 2023
1 check passed
@woo-chang woo-chang deleted the feat/#732 branch October 14, 2023 09:35
@woo-chang woo-chang restored the feat/#732 branch October 14, 2023 09:35
@woo-chang woo-chang deleted the feat/#732 branch October 14, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inyeong-kang inyeong-kang inyeong-kang approved these changes

@chsua chsua chsua approved these changes

Assignees

@Gilpop8663 Gilpop8663

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cmd + Enter를 입력했을 때 댓글이 작성되었으면 좋겠어요.
3 participants
@Gilpop8663 @inyeong-kang @chsua