-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
공지사항 목록 컴포넌트 / 공지사항 상세 컴포넌트 UI 구현 / 공지사항 ROUTER 설정 #749
Merged
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
7a9a4a4
feat: (#741) 모바일 버전 공지사항 목록 구현
Gilpop8663 7f841f3
feat: (#741) PC 버전 공지사항 리스트 스타일 구현
Gilpop8663 efc71a3
feat: (#741) 공지사항 세부 내용 컴포넌트 구현
Gilpop8663 b69cf4b
feat: 공지사항 리스트 페이지 구현
Gilpop8663 de57115
feat: (#741) 공지사항 세부 페이지 구현
Gilpop8663 962d1ae
feat: (#741) 공지사항 목록, 상세 페이지 router 설정
Gilpop8663 5b1f7f9
feat: (#741) 공지사항 웹 접근성 개선
Gilpop8663 6118863
style: (#741) 공지사항 목록에서는 채널톡 안보이도록 설정 및 padding 속성 설정
Gilpop8663 94de948
style: (#741) 공지사항 목록 ...이 짧게 설정되어서 width 값 재설정
Gilpop8663 3c60fa1
chore: (#741) 디자인 변경으로 인한 공지사항 보러가기 삭제
Gilpop8663 4795a40
Merge branch 'dev' of https://github.com/woowacourse-teams/2023-votog…
Gilpop8663 98375d0
refactor: (#741) 홈과 공지사항 목록 url을 PATH로 변경
Gilpop8663 4000618
refactor :(#741) 공지사항 목록을 감싸는 부모를 div에서 main으로 변경
Gilpop8663 bb9881b
refactor: (#741) 날짜를 string에서 StringDate로 타입 변경
Gilpop8663 0f730f9
style: (#741) 데스크탑일때 홈으로 버튼 안보이도록 설정
Gilpop8663 9ce18cd
chore: (#741) 읽은 사람에게 혼동을 주는 주석 제거
Gilpop8663 41aec0a
chore: (#741) router의 :id를 :noticeId로 이름 변경
Gilpop8663 284b2e1
refactor: (#741) StringDateOnly 타입 추가 및 api에서 생성 날짜를 변환시켜 날짜만 존재하도록 수정
Gilpop8663 60464df
refactor: (#741) Response를 Omit하여 만든 타입의 가독성을 높이기 위해 Response 타입을 이동
Gilpop8663 fd69f50
refactor: (#741) StringDateOnly Type 이름 변경
Gilpop8663 4d83d1a
chore: (#741) dev 브런치와 충돌 해결
Gilpop8663 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 4 additions & 8 deletions
12
frontend/src/components/notice/NoticeList/NoticeItem/index.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,7 @@ | ||
import { NoticeListResponse } from '@api/notice'; | ||
import { NoticeListResponse, NoticeResponse } from '@api/notice'; | ||
|
||
import { StringDate } from './time'; | ||
import { StringDateOnly } from './time'; | ||
|
||
export interface Notice { | ||
id: number; | ||
title: string; | ||
content: string; | ||
createdAt: StringDate; | ||
deadline: StringDate; | ||
bannerTitle: string; | ||
bannerSubtitle: string; | ||
} | ||
export type Notice = Omit<NoticeResponse, 'createdAt'> & { createdAt: StringDateOnly }; | ||
|
||
export type NoticeList = Omit<NoticeListResponse, 'notices'> & { noticeList: Notice[] }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
day까지만 포함시키겠다는 의미로
StringDateUpToDay 어떠신가요? (gpt의 도움을 받았습니다)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
더 명확하게 표현되는 것 같아 반영했습니다~