Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 삭제된 addText가 포함된 PR이 머지되어 발생하는 오류 해결 #764

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

chsua
Copy link
Collaborator

@chsua chsua commented Oct 17, 2023

🔥 연관 이슈

close: #763

📝 작업 요약

  • 삭제된 addText가 포함된 PR이 머지되어 발생하는 오류 해결
  • 토스트 미적용 부분 추가 적용(글쓸때 카테고리 4개이상 추가하려고 하면 alert 나옴)

⏰ 소요 시간

10분

🔎 작업 상세 설명

  • 오류 발생 부분 addText코드 삭제
  • 카테고리 훅 4개이상 추가 요청 시 토스트로 변경
    • 3개 다 채우면 자동으로 다중셀렉터 닫기
    • 4개 이상 하려고 하면 토스트 띄우고 다중셀렉터 닫기

@github-actions
Copy link

⚡️ Lighthouse report!

Category Score
🟠 Performance 61
🟠 Accessibilty 89
🟢 SEO 100
🟠 PWA 89
Category Score
🟢 First Contentful Paint 0.7 s
🟠 Largest Contentful Paint 3.6 s
🔴 Total Blocking Time 2,210 ms
🟢 Cumulative Layout Shift 0
🟢 Speed Index 3.2 s

Copy link
Collaborator

@Gilpop8663 Gilpop8663 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍👍👍

@Gilpop8663
Copy link
Collaborator

어프로브했습니다~~

fe-리뷰완

@chsua chsua merged commit d08d34c into dev Oct 17, 2023
2 checks passed
@woo-chang woo-chang deleted the feat/#763 branch October 17, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 삭제된 addText가 포함된 PR이 머지되어 발생하는 오류 해결
3 participants