Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

알림 읽기 기능 구현 #775

Merged
merged 23 commits into from
Oct 18, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
5096f62
chore: (#766) 코드 컨벤션 수정
woo-chang Oct 18, 2023
d2f942c
feat: (#766) 알림 읽음 기능 구현
woo-chang Oct 18, 2023
3c68733
refactor: (#766) 알림 리팩터링
woo-chang Oct 18, 2023
4966dd2
feat: (#766) 알림 대상 검증 기능 구현
woo-chang Oct 18, 2023
c8244aa
feat: (#766) 알림 읽는 기능 구현
woo-chang Oct 18, 2023
04d5212
feat: (#766) 알림 읽기 API 구현
woo-chang Oct 18, 2023
85fa66d
fix: (#766) 테이블 추가
woo-chang Oct 18, 2023
b3a4d72
fix: (#766) 비동기 테스트를 위한 sleep 추가
woo-chang Oct 18, 2023
289b63c
feat: (#766) 알림 타입 추가
woo-chang Oct 18, 2023
9e6273a
test: (#766) 알림 타입이 없는 경우 테스트
woo-chang Oct 18, 2023
4abffa8
feat: (#766) 신고 알림 읽는 기능 구현
woo-chang Oct 18, 2023
40618e1
feat: (#766) 알림 액션 타입 생성 기능 구현
woo-chang Oct 18, 2023
3998d1d
feat: (#766) 타입에 따른 알림 읽기 기능 구현
woo-chang Oct 18, 2023
0e10b78
docs: (#766) 예외 상황 문서화
woo-chang Oct 18, 2023
0242e3a
chore: (#766) 코드 컨벤션 수정
woo-chang Oct 18, 2023
b3e0ba1
docs: (#766) 예외 발생 문서화
woo-chang Oct 18, 2023
0d9211f
Merge branch 'dev' into feat/#766
woo-chang Oct 18, 2023
b5b54c9
Merge branch 'dev' into feat/#766
woo-chang Oct 18, 2023
a54c9b2
chore: (#766) 코드 컨벤션 수정
woo-chang Oct 18, 2023
6f432d7
chore: (#766) 개행 컨벤션 수정
woo-chang Oct 18, 2023
d6f81ec
Merge branch 'dev' into feat/#766
woo-chang Oct 18, 2023
68e6bec
fix: (#766) DB 예약어 수정
woo-chang Oct 18, 2023
4355004
fix: (#766) 이벤트 테스트 임시 수정
woo-chang Oct 18, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,16 @@

import com.votogether.domain.alarm.dto.ReportActionAlarmResponse;
import com.votogether.domain.alarm.dto.ReportActionResponse;
import com.votogether.domain.alarm.service.AlarmService;
import com.votogether.domain.alarm.dto.response.PostAlarmResponse;
import com.votogether.domain.alarm.service.AlarmQueryService;
import com.votogether.domain.member.entity.Member;
import com.votogether.global.jwt.Auth;
import jakarta.validation.constraints.PositiveOrZero;
import java.util.List;
import lombok.RequiredArgsConstructor;
import org.springframework.http.ResponseEntity;
import org.springframework.validation.annotation.Validated;
import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.PathVariable;
import org.springframework.web.bind.annotation.RequestMapping;
import org.springframework.web.bind.annotation.RequestParam;
Expand All @@ -19,25 +21,33 @@
@RequiredArgsConstructor
@RequestMapping("/alarms")
@RestController
public class AlarmCommandController implements AlarmCommandControllerDocs {
public class AlarmQueryController implements AlarmQueryControllerDocs {

private final AlarmService alarmService;
private final AlarmQueryService alarmQueryService;

@RequestMapping("/report")
@GetMapping("/content")
public ResponseEntity<List<PostAlarmResponse>> getPostAlarm(
@RequestParam @PositiveOrZero(message = "페이지는 0이상 정수만 가능합니다.") final int page
) {
final List<PostAlarmResponse> postAlarmResponses = alarmQueryService.getPostAlarm(page);
return ResponseEntity.ok(postAlarmResponses);
}

@GetMapping("/report")
public ResponseEntity<List<ReportActionAlarmResponse>> getReportActionAlarms(
@RequestParam @PositiveOrZero(message = "페이지는 0이상 정수만 가능합니다.") final int page,
@Auth final Member member
) {
final List<ReportActionAlarmResponse> response = alarmService.getReportActionAlarms(member, page);
final List<ReportActionAlarmResponse> response = alarmQueryService.getReportActionAlarms(member, page);
return ResponseEntity.ok(response);
}

@RequestMapping("/report/{id}")
@GetMapping("/report/{id}")
public ResponseEntity<ReportActionResponse> getReportActionAlarm(
@PathVariable("id") final Long reportActionAlarmId,
@Auth final Member member
) {
final ReportActionResponse response = alarmService.getReportActionAlarm(reportActionAlarmId, member);
final ReportActionResponse response = alarmQueryService.getReportActionAlarm(reportActionAlarmId, member);
return ResponseEntity.ok(response);
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
package com.votogether.domain.alarm.controller;

import com.votogether.domain.alarm.dto.ReportActionAlarmResponse;
import com.votogether.domain.alarm.dto.ReportActionResponse;
import com.votogether.domain.alarm.dto.response.PostAlarmResponse;
import com.votogether.domain.member.entity.Member;
import com.votogether.global.exception.ExceptionResponse;
import io.swagger.v3.oas.annotations.Operation;
import io.swagger.v3.oas.annotations.Parameter;
import io.swagger.v3.oas.annotations.media.Content;
import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.responses.ApiResponse;
Expand All @@ -12,10 +16,13 @@
import java.util.List;
import org.springframework.http.ResponseEntity;

@Tag(name = "알림", description = "알림 API")
@Tag(name = "알림 조회", description = "알림 조회 API")
public interface AlarmQueryControllerDocs {

@Operation(summary = "게시글 내역 알림 조회", description = "게시글 내역 알림을 조회한다.")
@Operation(
summary = "게시글 내역 알림 조회",
description = "게시글 내역 알림을 조회한다."
)
@ApiResponses({
@ApiResponse(
responseCode = "200",
Expand All @@ -31,4 +38,31 @@ ResponseEntity<List<PostAlarmResponse>> getPostAlarm(
@PositiveOrZero(message = "페이지는 0이상 정수만 가능합니다.") final int page
);

@Operation(
summary = "신고조치알림 조회",
description = "신고조치알림목록을 조회한다."
)
@ApiResponse(
responseCode = "201",
description = "조회 성공"
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

페이지가 0미만이면 400 반환한다는 내용도 포함되면 좋을 것 같아요 :)

ResponseEntity<List<ReportActionAlarmResponse>> getReportActionAlarms(
@Parameter(description = "현재 페이지 위치", example = "0")
@PositiveOrZero(message = "페이지는 0이상 정수만 가능합니다.") final int page,
final Member member
);

@Operation(
summary = "신고조치알림 상세 조회",
description = "신고조치알림를 상세 조회한다."
)
@ApiResponse(
responseCode = "201",
description = "조회 성공"
)
ResponseEntity<ReportActionResponse> getReportActionAlarm(
@Parameter(description = "신고조치알림 ID", example = "1") final Long reportActionAlarmId,
final Member member
);

}

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,14 +1,21 @@
package com.votogether.domain.alarm.service;

import com.votogether.domain.alarm.dto.ReportActionAlarmResponse;
import com.votogether.domain.alarm.dto.ReportActionResponse;
import com.votogether.domain.alarm.dto.response.PostAlarmResponse;
import com.votogether.domain.alarm.entity.Alarm;
import com.votogether.domain.alarm.entity.ReportActionAlarm;
import com.votogether.domain.alarm.entity.vo.AlarmType;
import com.votogether.domain.alarm.exception.ReportActionAlarmExceptionType;
import com.votogether.domain.alarm.repository.AlarmRepository;
import com.votogether.domain.alarm.repository.ReportActionAlarmRepository;
import com.votogether.domain.member.entity.Member;
import com.votogether.global.exception.NotFoundException;
import java.util.List;
import lombok.RequiredArgsConstructor;
import org.springframework.data.domain.PageRequest;
import org.springframework.data.domain.Slice;
import org.springframework.data.domain.Sort;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;

Expand All @@ -21,6 +28,7 @@ public class AlarmQueryService {
private static final String NICKNAME_WHEN_POST_CLOSING = "";

private final AlarmRepository alarmRepository;
private final ReportActionAlarmRepository reportActionAlarmRepository;

public List<PostAlarmResponse> getPostAlarm(final int page) {
final PageRequest pageRequest = PageRequest.of(page, BASIC_PAGE_SIZE);
Expand All @@ -46,4 +54,23 @@ private String makeNicknameBy(final Alarm alarm) {
return member.getNickname();
}

public List<ReportActionAlarmResponse> getReportActionAlarms(final Member member, final int page) {
final PageRequest pageRequest = PageRequest.of(page, BASIC_PAGE_SIZE,
Sort.by(Sort.Direction.DESC, "createdAt"));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
final PageRequest pageRequest = PageRequest.of(page, BASIC_PAGE_SIZE,
Sort.by(Sort.Direction.DESC, "createdAt"));
final PageRequest pageRequest = PageRequest.of(
page,
BASIC_PAGE_SIZE,
Sort.by(Sort.Direction.DESC, "createdAt")
);

이렇게 바꿔보는 것은 어떨까요

final List<ReportActionAlarm> reportActionAlarms = reportActionAlarmRepository
.findByMember(member, pageRequest);

return reportActionAlarms.stream()
.map(ReportActionAlarmResponse::from)
.toList();
}

public ReportActionResponse getReportActionAlarm(final Long reportActionAlarmId, final Member member) {
final ReportActionAlarm reportActionAlarm = reportActionAlarmRepository
.findByIdAndMember(reportActionAlarmId, member)
.orElseThrow(() -> new NotFoundException(ReportActionAlarmExceptionType.NOT_FOUND));

return ReportActionResponse.from(reportActionAlarm);
}

}

This file was deleted.

This file was deleted.

Loading