커넥션풀 관련 설정 추가 + 회원탈퇴시 fk 관련 삭제 로직 추가 #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjdtls690
requested changes
Oct 19, 2023
Comment on lines
94
to
96
| PageRequest pageRequestB = PageRequest.of(1, 10); | ||
| List<ReportActionAlarm> reportActionAlarmsB = reportActionAlarmRepository.findByMemberOrderByCreatedAtDesc( | ||
| member, pageRequestB); |
Comment on lines
57
to
58
| List<ReportActionAlarm> reportActionAlarms = reportActionAlarmRepository.findByMemberOrderByCreatedAtDesc( | ||
| member, pageRequest); |
There was a problem hiding this comment.
Suggested change
| List<ReportActionAlarm> reportActionAlarms = reportActionAlarmRepository.findByMemberOrderByCreatedAtDesc( | |
| member, pageRequest); | |
| List<ReportActionAlarm> reportActionAlarms = reportActionAlarmRepository | |
| .findByMemberOrderByCreatedAtDesc(member, pageRequest); |
이렇게 개행 바꾸는 것은 어떨까요
There was a problem hiding this comment.
좋아요 자꾸 자동정렬이 이상하게 되네요
Comment on lines
91
to
92
| List<ReportActionAlarm> reportActionAlarmsA = reportActionAlarmRepository.findByMemberOrderByCreatedAtDesc( | ||
| member, pageRequestA); |
Comment on lines
-97
to
+99
| .as(new ParameterizedTypeReference<List<ReportActionAlarmResponse>>() { | ||
| }.getType()); | ||
| .as(new TypeRef<>() { | ||
| }); |
Comment on lines
+513
to
+516
| assertAll( | ||
| () -> assertThat(memberRepository.findAll()).isEmpty(), | ||
| () -> assertThat(reportActionAlarmRepository.findAll()).isEmpty() | ||
| ); |
There was a problem hiding this comment.
assertAll 대신 assertSoftly 써보는 것은 어떨까요.
개인적으로 그게 더 친절하게 안내해주더라구요.
woo-chang
requested changes
Oct 19, 2023
| @@ -9,8 +9,10 @@ | |||
|
|
|||
| public interface ReportActionAlarmRepository extends JpaRepository<ReportActionAlarm, Long> { | |||
|
|
|||
| List<ReportActionAlarm> findByMember(final Member member, final Pageable pageable); | |||
| List<ReportActionAlarm> findByMemberOrderByCreatedAtDesc(final Member member, final Pageable pageable); | |||
There was a problem hiding this comment.
인덱스를 탈 수 있는 ID를 정렬에 사용하는게 좋을 것 같아요 :)
There was a problem hiding this comment.
무슨말씀인지 잘 이해가 안되요 ㅠ
There was a problem hiding this comment.
auto increment 전략을 사용하고 있기에 id순이 생성순과 동일하고, id에는 PK 인덱스가 걸려있지만, createdAt에는 인덱스가 걸려있지 않아 인덱스가 걸려있는 id를 사용하는게 좋을 것 같다는 의견이었습니다 !
There was a problem hiding this comment.
아하 어차피 id로 최신순으로 이미 정렬이 가능하니 id로 가져온다는 말씀이군요! 수정해보겠습니다!
| reportActionAlarmRepository.deleteAllById(reportActionAlarmIds); | ||
| } | ||
|
|
||
| private void deleteNotices(final Member member) { |
Comment on lines
+7
to
+10
| hikari: | ||
| maximumPoolSize: ${MAXIMUM_POOL_SIZE} | ||
| connectionTimeout: ${CONNECTION_TIMEOUT} | ||
| maxLifetime: ${MAX_LIFETIME} |
There was a problem hiding this comment.
이외의 설정도 많았던 것 같은데 3개의 설정만 해주시는 이유가 있나요?!
There was a problem hiding this comment.
그 이외의 설정값들은 default값이여서 따로 설정은 하지 않았습니다!
jeomxon
approved these changes
Oct 19, 2023
woo-chang
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
close: #767
📝 작업 요약
⏰ 소요 시간
30분
🔎 작업 상세 설명
🌟 논의 사항
Q. 이벤트리스너 테스트에서 @disable 을 붙인 이유는 깃허브 액션때문에 추가하신건가요?