-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(회원) 선호 카테고리 삭제 기능 구현 #79
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f3e8263
feat: (#67) (회원) 선호 카테고리 삭제 API 기능 구현
aiaiaiai1 f4b1f67
feat: (#67) Swagger 어노테이션 추가
aiaiaiai1 383519f
test: (#67) Controller 단위테스트, Service 통합테스트 추가
aiaiaiai1 ee2f013
style: (#67) final 키워드 추가
aiaiaiai1 07b3288
refactor: (#68) CategoryResponse 파라미터 값 수정
aiaiaiai1 e3a022d
feat: (#68) (회원) 카테고리 목록 전체 조회 API 추가
aiaiaiai1 f57dd51
teat: (#68) (회원) 레파지토리 테스트 추가
aiaiaiai1 b6949bb
teat: (#67) 선호하는 카테고리에 없는 카테고리를 삭제하는 경우 예외 테스트 추가
aiaiaiai1 4a82237
refactor: (#67) 개행 및 스태틱 임포트 리펙터링
aiaiaiai1 03dcd00
feat: (#67) Swagger 어노테이션 에러 응답 설명 추가
aiaiaiai1 c6e04fe
merge
aiaiaiai1 7d3c827
refactor: (#67) url 오타 수정
aiaiaiai1 8694859
refactor: (#67) 개행 및 컨벤션 수정
aiaiaiai1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 7 additions & 2 deletions
9
backend/src/main/java/com/votogether/domain/category/dto/response/CategoryResponse.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,20 @@ | ||
package com.votogether.domain.category.dto.response; | ||
|
||
import com.votogether.domain.category.entity.Category; | ||
import java.util.List; | ||
|
||
public record CategoryResponse( | ||
Long id, | ||
String name, | ||
boolean isFavorite | ||
) { | ||
|
||
public CategoryResponse(final Category category) { | ||
this(category.getId(), category.getName(), false); | ||
public CategoryResponse(final Category category, final boolean isFavorite) { | ||
this(category.getId(), category.getName(), isFavorite); | ||
} | ||
|
||
public CategoryResponse(final Category category, final List<Category> favoriteCategories) { | ||
this(category.getId(), category.getName(), favoriteCategories.contains(category)); | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80 changes: 80 additions & 0 deletions
80
backend/src/test/java/com/votogether/domain/category/contorller/CategoryControllerTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
package com.votogether.domain.category.contorller; | ||
|
||
import static org.hamcrest.Matchers.equalTo; | ||
import static org.hamcrest.Matchers.nullValue; | ||
import static org.mockito.ArgumentMatchers.any; | ||
import static org.mockito.BDDMockito.given; | ||
import static org.mockito.Mockito.doNothing; | ||
|
||
import com.votogether.domain.category.dto.response.CategoryResponse; | ||
import com.votogether.domain.category.entity.Category; | ||
import com.votogether.domain.category.service.CategoryService; | ||
import io.restassured.module.mockmvc.RestAssuredMockMvc; | ||
import java.util.List; | ||
import org.junit.jupiter.api.BeforeEach; | ||
import org.junit.jupiter.api.DisplayName; | ||
import org.junit.jupiter.api.Test; | ||
import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest; | ||
import org.springframework.boot.test.mock.mockito.MockBean; | ||
import org.springframework.http.HttpStatus; | ||
|
||
@WebMvcTest(CategoryController.class) | ||
class CategoryControllerTest { | ||
|
||
@MockBean | ||
CategoryService categoryService; | ||
|
||
@BeforeEach | ||
void setUp() { | ||
RestAssuredMockMvc.standaloneSetup(new CategoryController(categoryService)); | ||
} | ||
|
||
@Test | ||
@DisplayName("전체 카테고리 목록을 조회한다.") | ||
void getAllCategories() { | ||
// given | ||
Category category = Category.builder() | ||
.name("개발") | ||
.build(); | ||
given(categoryService.getAllCategories()).willReturn(List.of(new CategoryResponse(category, false))); | ||
|
||
// when | ||
RestAssuredMockMvc. | ||
given().log().all() | ||
.when().get("/categories/guest") | ||
.then().log().all() | ||
.status(HttpStatus.OK) | ||
.body("[0].id", nullValue()) | ||
.body("[0].name", equalTo("개발")) | ||
.body("[0].isFavorite", equalTo(false)); | ||
} | ||
|
||
@Test | ||
@DisplayName("선호하는 카테고리를 선호 카테고리 목록에 추가한다.") | ||
void addFavoriteCategory() { | ||
// given | ||
doNothing().when(categoryService).addFavoriteCategory(any(), any()); | ||
|
||
// when & then | ||
RestAssuredMockMvc. | ||
given().log().all() | ||
.when().post("/categories/{categoryId}/like", 1) | ||
.then().log().all() | ||
.status(HttpStatus.CREATED); | ||
} | ||
|
||
@Test | ||
@DisplayName("선호 카테고리를 삭제한다.") | ||
void removeFavoriteCategory() { | ||
// given | ||
doNothing().when(categoryService).removeFavoriteCategory(any(), any()); | ||
|
||
// when & then | ||
RestAssuredMockMvc. | ||
given().log().all() | ||
.when().delete("/categories/{categoryId}/like", 1) | ||
.then().log().all() | ||
.status(HttpStatus.NO_CONTENT); | ||
} | ||
|
||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q
doNothing().when()은 어떤 역할을 하나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
목 객체 서비스가 해당 메서드를 실행하면 아무것도 응답하지 않는 역할을 합니다