[BE] 깃허브 API 비동기 작업시 ThreadPoolExecutor 주입(#764) #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Test Results 67 files 67 suites 8s ⏱️ Results for commit 6ca2bc3. |
ashsty
approved these changes
Nov 18, 2024
| import java.util.function.Supplier; | ||
|
|
||
| public class FutureUtil { | ||
|
|
||
| public static <T> CompletableFuture<T> supplyAsync(Supplier<T> supplier) { | ||
| return CompletableFuture.supplyAsync(supplier); | ||
| } | ||
|
|
||
| public static <T> CompletableFuture<T> supplyAsync(final Supplier<T> supplier, final Executor executor) { |
There was a problem hiding this comment.
파라미터에 final 붙어 있는 이유가 있나요? ㅇ.ㅇ
없으면 빼도 괜찮을 것 같습니다!
hjk0761
approved these changes
Nov 18, 2024
Comment on lines
+15
to
+17
| executor.setCorePoolSize(100); | ||
| executor.setMaxPoolSize(200); | ||
| executor.setQueueCapacity(50); |
There was a problem hiding this comment.
적절한 세팅인 것 같아요 👍
지금 상황에서 말한것처럼 큰 부하는 없을 것 같아 좋은 것 같습니다
고생했어용!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
✨ PR 세부 내용
이슈에 설명한 내용과 비슷하며
FutureUtil테스트를 통해 검증했습니다.스레드 사용 설정은
t2.micro사양인 CPU 1 core, Memory 1G 로 해도Core 1000, Max 2000, �Queue 500해당 값에 대해 잘 작동하는걸 확인했습니다.( DB 및 다른 의존성 제거하고 스레드 부분만 진행 )
당장 이렇게 TPS 가 나오지 않을거라 생각해서 부하가 크게 없고, 요청이 많이 와도 문제없을 100 200 50 으로 설정했습니다.