feat-be: 지원폼 답변 제출 기능 #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This reverts commit 314654a.
|
1722429097.121259 |
📌 Test Coverage Report
|
HyungHoKim00
requested changes
Jul 31, 2024
backend/src/main/java/com/cruru/applyform/domain/ApplyForm.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/cruru/applyform/service/ApplyFormService.java
Outdated
Show resolved
Hide resolved
| @PathVariable(name = "applyform_id") long applyFormId | ||
| ) { | ||
| applyFormService.submit(request, applyFormId); | ||
| return ResponseEntity.created(URI.create("/v1/applyform/" + applyFormId)).build(); |
There was a problem hiding this comment.
[질문] submit은 지원자 입장에서 제출하는 것 같은데, uri는 빈 질문지를 볼 수 있도록 되어있네요. 의도된 부분인가요?
There was a problem hiding this comment.
제출 후에 어떤 applyForm으로 제출했는지 클라이언트에게 알려주기 위해 작성했습니다.
backend/src/test/java/com/cruru/applyform/controller/ApplyFormControllerTest.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/cruru/applyform/controller/dto/AnswerCreateRequest.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/cruru/applyform/service/ApplyFormService.java
Outdated
Show resolved
Hide resolved
backend/src/test/java/com/cruru/applyform/controller/ApplyFormControllerTest.java
Outdated
Show resolved
Hide resolved
|
|
||
| Process firstProcess = processRepository.findAllByDashboardId(applyForm.getDashboard().getId()).stream() | ||
| .min(Comparator.comparingInt(Process::getSequence)) | ||
| .orElseThrow(InternalServerException::new); |
There was a problem hiding this comment.
[질문] 500번 응답을 주는 이유가 뭔가요?
There was a problem hiding this comment.
대시보드 생성 시점에서 적어도 하나의 프로세스(서류 제출)가 존재하지 않는다면 서버의 오류라고 판단했습니다.
Chocochip101
force-pushed
the
be-212-APP_ADD_01
branch
from
2fda0a7 to
54605bd
Compare
cutehumanS2
requested changes
Aug 1, 2024
backend/src/main/java/com/cruru/applyform/exception/ApplyFormNotFoundException.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/cruru/applyform/service/ApplyFormService.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/cruru/question/exception/QuestionNotFoundException.java
Outdated
Show resolved
Hide resolved
cutehumanS2
approved these changes
Aug 1, 2024
xogns1514
requested changes
Aug 1, 2024
backend/src/test/java/com/cruru/applyform/domain/repository/ApplyFormRepositoryTest.java
Outdated
Show resolved
Hide resolved
Chocochip101
added a commit
that referenced
this pull request
Aug 12, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Do Yeop Kim <113661364+Dobby-Kim@users.noreply.github.com> Co-authored-by: Kwoun Ki Ho <fingercut3822@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue description
목적
작업 세부사항
참고 사항
APP_ADD_01
closes #212